Bug 160614

Summary: compilePutByValForIntTypedArray() has a slow path in the middle of its processing
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, saam
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 160355    
Attachments:
Description Flags
Patch keith_miller: review+

Michael Saboff
Reported 2016-08-05 15:39:39 PDT
SpeculativeJIT::compilePutByValForIntTypedArray() has a slow path call to operationToInt32() in the middle of the code it generates. This violates the rule that slow paths need to finish the processing of the node. This was found while working on <https://bugs.webkit.org/show_bug.cgi?id=160355>, but I can't seem to construct a test that hits it without the argument register code.
Attachments
Patch (6.12 KB, patch)
2016-08-05 16:15 PDT, Michael Saboff 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2016-08-05 16:15:23 PDT
Created attachment 285459 [details] Patch
Keith Miller
Comment 2 2016-08-05 16:45:27 PDT
Comment on attachment 285459 [details] Patch r=me.
Keith Miller
Comment 3 2016-08-05 16:45:55 PDT
This makes me :( though.
Michael Saboff
Comment 4 2016-08-05 17:03:09 PDT
Committed r204204: <http://trac.webkit.org/changeset/204204>
Note You need to log in before you can comment on or make changes to this bug.