Bug 160566

Summary: Web Inspector: UI polish for Edit Breakpoint dialog
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Clipped condition field
none
[Patch] Proposed Fix none

Matt Baker
Reported 2016-08-04 13:56:39 PDT
Created attachment 285359 [details] [Image] Clipped condition field The add/remove action buttons should be simplified and their positions swapped (add should be first, then remove) to match Xcode 8. Also, the condition field should update its width when the popover width changes. Currently the CodeMirror input is clipped by ~40px when the popover resizes (see screenshot). Steps to Reproduce: 1. Edit Breakpoint 2. Type stuff in condition field until cursor scrolls => Padding looks good! 3. Add an action => Popover width changes, condition field becomes wider, but editable portion stays the same width.
Attachments
[Image] Clipped condition field (121.76 KB, image/png)
2016-08-04 13:56 PDT, Matt Baker 		no flags
Details
[Patch] Proposed Fix (6.88 KB, patch)
2016-08-04 14:03 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-08-04 13:57:03 PDT
<rdar://problem/27706378>
Matt Baker
Comment 2 2016-08-04 14:03:59 PDT
Created attachment 285360 [details] [Patch] Proposed Fix
Timothy Hatcher
Comment 3 2016-08-04 15:31:12 PDT
Comment on attachment 285360 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=285360&action=review > Source/WebInspectorUI/UserInterface/Views/BreakpointPopoverController.css:74 > + width: 360px; /* NOTE: Fixed value, manually tuned to .edit-breakpoint-popover-content width. */ Could this be a calc() instead?
Matt Baker
Comment 4 2016-08-04 15:41:25 PDT
Comment on attachment 285360 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=285360&action=review >> Source/WebInspectorUI/UserInterface/Views/BreakpointPopoverController.css:74 >> + width: 360px; /* NOTE: Fixed value, manually tuned to .edit-breakpoint-popover-content width. */ > > Could this be a calc() instead? I tried calc initially, but had some issues. I'll try again before landing.
WebKit Commit Bot
Comment 5 2016-08-04 16:47:29 PDT
Comment on attachment 285360 [details] [Patch] Proposed Fix Clearing flags on attachment: 285360 Committed r204152: <http://trac.webkit.org/changeset/204152>
WebKit Commit Bot
Comment 6 2016-08-04 16:47:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.