Summary: | Unicode not being interpreted correctly in Web Inspector source view | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dominic Mitchell <dom> | ||||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Alexey Proskuryakov <ap> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Minor | CC: | ap, sam | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 523.x (Safari 3) | ||||||||||||
Hardware: | Mac | ||||||||||||
OS: | OS X 10.5 | ||||||||||||
URL: | http://plasmasturm.org/about/ | ||||||||||||
Attachments: |
|
Description
Dominic Mitchell
2007-11-19 13:38:46 PST
Created attachment 17407 [details]
Correctly rendered view of the page.
Created attachment 17408 [details]
Correctly rendered view in the DOM inspector.
Created attachment 17409 [details]
Incorrectly rendered in the source inspector.
Created attachment 17420 [details]
proposed fix
Comment on attachment 17420 [details]
proposed fix
+ if (resource->requestURL == resource->loader->requestURL()) {
buffer = resource->loader->mainResourceData();
- else {
+ textEncodingName = resource->loader->frame()->document()->inputEncoding();
+ } else {
Don't need braces here
+ virtual String encoding() const;
Can these methods return a const String&? Or are they returning transient Strings?
r=me
(In reply to comment #6) > (From update of attachment 17420 [details] [edit]) > + if (resource->requestURL == resource->loader->requestURL()) { > buffer = resource->loader->mainResourceData(); > - else { > + textEncodingName = > resource->loader->frame()->document()->inputEncoding(); > + } else { > > Don't need braces here I think you DO need braces here. :) Committed revision 27937. Wow! Thanks for the quick attention! |