Bug 160540 – Introduce a MathMLAnnotationElement class for the annotation/annotation-xml elements

• Component: MathML
• Status: RESOLVED FIXED

[Frédéric Wang (:fredw)]

annotation can only contain text whereas the annotation-xml element can contain some elements as described in the HTML5 RelaxNG schema. For this reason, they have been implemented in MathMLTextElement and MathMLInlineContainerElement respectively. However, they are actually closer to each other than to token elements or presentation containers. In particular, they have their own attributes and are not supposed to handle things like mathvariant or displaystyle. We should introduce a MathMLAnnotationClass to shar their implementation.

[Frédéric Wang (:fredw)]

Created attachment 285307 [details]
Patch

[Frédéric Wang (:fredw)]

Comment on attachment 285307 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285307&action=review

> Source/WebCore/CMakeLists.txt:1990
> +    mathml/MathMLAnnotationElement.cpp

The windows bot seems happy, but I should also update Source/WebCore/mathml/MathMLAllInOne.cpp

[Darin Adler]

Comment on attachment 285307 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285307&action=review

> Source/WebCore/mathml/MathMLAnnotationElement.cpp:32
> +#include "HTMLElement.h"

No need to include this, since this is a base class of HTMLHtmlElement.

> Source/WebCore/mathml/MathMLAnnotationElement.cpp:38
> +#include "SVGElement.h"

No need to include this, since this is a base class of SVGSVGElement.

> Source/WebCore/mathml/MathMLAnnotationElement.h:44
> +    void attributeChanged(const QualifiedName&, const AtomicString& oldValue, const AtomicString& newValue, AttributeModificationReason) override;

Should be final, not override.

[Frédéric Wang (:fredw)]

Created attachment 286562 [details]
Final Patch

[WebKit Commit Bot]

Comment on attachment 286562 [details]
Final Patch

Clearing flags on attachment: 286562

Committed r204692: <http://trac.webkit.org/changeset/204692>