Bug 160518 – [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Carlos Alberto Lopez Perez]

There are some missing dependencies on the script:

- libxslt is a build dependency (see r170751), but is not listed in the install-dependencies script.
- psmisc is also required for the webkit tests, there are a number of calls to the killall program that comes with it.

[Carlos Alberto Lopez Perez]

Created attachment 285258 [details]
Patch

[Michael Catanzaro]

Comment on attachment 285258 [details]
Patch

Thanks for updating all distros.

[Carlos Alberto Lopez Perez]

I have missed some dependencies on the previous patch.

I have detected this trying to run the script

$ Tools/Scripts/run-benchmark --platform gtk --browser minibrowser --plan animometer

inside a fedora 24 chroot.


It seems that at least python2-zope-interface and python2-psutil are also needed.

$ /usr/bin/python /home/clopez/webkit/webkit/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py /tmp/tmp057wFj
Traceback (most recent call last):
  File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py", line 14, in <module>
    from twisted.web import static, server
  File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/twisted/twisted/web/static.py", line 16, in <module>
    from zope.interface import implements
ImportError: No module named zope.interface


I'm going to upload an updated patch with this two new deps.

[Carlos Alberto Lopez Perez]

Created attachment 285291 [details]
Patch

[Michael Catanzaro]

I know it's harder, but shouldn't the python packages be autoinstalled under Tools/Scripts/webkitpy/thirdparty/autoinstalled?

[Carlos Alberto Lopez Perez]

(In reply to comment #5)
> I know it's harder, but shouldn't the python packages be autoinstalled under
> Tools/Scripts/webkitpy/thirdparty/autoinstalled?

python zope-interface can be installed that way.

python-psutil can not because it requires binary libraries to be built and the current installer don't supports installing libraries that require to build binary shared libs. It only unpacks python files.

[Carlos Alberto Lopez Perez]

Created attachment 285327 [details]
Patch

[Michael Catanzaro]

Comment on attachment 285327 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285327&action=review

> Tools/Scripts/webkitpy/thirdparty/__init__.py:157
> +        installer.install(url="https://pypi.python.org/packages/source/z/zope.interface/zope.interface-4.1.3.tar.gz#md5=9ae3d24c0c7415deb249dd1a132f0f79", url_subpath="zope.interface-4.1.3/src/zope")

Does our installer not handle pip dependencies?

[Carlos Alberto Lopez Perez]

(In reply to comment #8)
> Comment on attachment 285327 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=285327&action=review
> 
> > Tools/Scripts/webkitpy/thirdparty/__init__.py:157
> > +        installer.install(url="https://pypi.python.org/packages/source/z/zope.interface/zope.interface-4.1.3.tar.gz#md5=9ae3d24c0c7415deb249dd1a132f0f79", url_subpath="zope.interface-4.1.3/src/zope")
> 
> Does our installer not handle pip dependencies?

As far as I see, it does not. It downloads the tarballs and unpacks them, but it don't runs pip or is able to rely on python distutils.

But I might be missing something. Do you know if it handles pip dependencies?

[Michael Catanzaro]

Comment on attachment 285327 [details]
Patch

Nope, just asking!

[Carlos Alberto Lopez Perez]

Comment on attachment 285327 [details]
Patch

Clearing flags on attachment: 285327

Committed r204155: <http://trac.webkit.org/changeset/204155>

[Carlos Alberto Lopez Perez]

All reviewed patches have been landed.  Closing bug.