Bug 160511

Summary: [Web IDL] Add support for 'any' type in dictionaries
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, commit-queue, darin, esprehn+autocc, kondapallykalyan, sam, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=160487
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2016-08-03 09:37:56 PDT
Add support for 'any' type in dictionaries.
Attachments
Patch (6.28 KB, patch)
2016-08-03 09:47 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (6.26 KB, patch)
2016-08-04 15:06 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.29 KB, patch)
2016-08-04 18:39 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-08-03 09:47:04 PDT
Created attachment 285240 [details] Patch
Chris Dumez
Comment 2 2016-08-03 09:50:25 PDT
Comment on attachment 285240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285240&action=review > Source/WebCore/bindings/js/JSDOMConvert.h:122 > + using OptionalValue = JSC::JSValue; // Use an empty JSValue to mean an optional value was not present. Alternatively, we could pass jsUndefined() to the implementation if the member is not present since I don't think we need to distinguish missing member from member being undefined in this case. However, this would require some minor tweaking of the bindings generator. Let me know if you'd prefer passing undefined instead of JSValue().
Chris Dumez
Comment 3 2016-08-04 15:06:39 PDT
Created attachment 285368 [details] Patch
Chris Dumez
Comment 4 2016-08-04 15:07:17 PDT
Comment on attachment 285368 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285368&action=review > Source/WebCore/bindings/js/JSDOMConvert.h:133 > + using OptionalValue = JSC::JSValue; // Use an empty JSValue to mean an optional value was not present. Alternatively, we could pass jsUndefined() to the implementation if the member is not present since I don't think we need to distinguish missing member from member being undefined in this case. However, this would require some minor tweaking of the bindings generator. Let me know if you'd prefer passing undefined instead of JSValue().
Sam Weinig
Comment 5 2016-08-04 18:25:01 PDT
Comment on attachment 285368 [details] Patch I slightly prefer jsUndefined(), just cause I am not sure where else we use JSValue()
Chris Dumez
Comment 6 2016-08-04 18:39:00 PDT
Created attachment 285391 [details] Patch
Chris Dumez
Comment 7 2016-08-04 18:39:15 PDT
(In reply to comment #5) > Comment on attachment 285368 [details] > Patch > > I slightly prefer jsUndefined(), just cause I am not sure where else we use > JSValue() Done.
WebKit Commit Bot
Comment 8 2016-08-05 19:34:32 PDT
Comment on attachment 285391 [details] Patch Clearing flags on attachment: 285391 Committed r204216: <http://trac.webkit.org/changeset/204216>
WebKit Commit Bot
Comment 9 2016-08-05 19:34:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.