Bug 160488

Summary:

Update breaking rules to match ICU 57

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, buildbot, cdumez, cmarcelo, commit-queue, dino, jonlee, mitz, rniwa, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Needs tests	none
Patch	none
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews107 for mac-yosemite-wk2	none
Archive of layout-test-results from ews113 for mac-yosemite	none
Patch	darin: review+, buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews106 for mac-yosemite-wk2	none
Archive of layout-test-results from ews116 for mac-yosemite	none

Myles C. Maxfield

Reported 2016-08-02 20:21:38 PDT

Update breaking rules to match ICU 57

Attachments
Needs tests (2.42 KB, patch) 2016-08-02 20:22 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (4.71 KB, patch) 2016-08-02 21:12 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.00 MB, application/zip) 2016-08-02 21:52 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.13 MB, application/zip) 2016-08-02 21:55 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews113 for mac-yosemite (1.56 MB, application/zip) 2016-08-02 22:19 PDT, Build Bot	no flags	Details
Patch (5.24 KB, patch) 2016-08-02 22:23 PDT, Myles C. Maxfield	darin: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-yosemite (961.48 KB, application/zip) 2016-08-02 23:09 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (937.54 KB, application/zip) 2016-08-02 23:12 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-yosemite (1.59 MB, application/zip) 2016-08-02 23:20 PDT, Build Bot	no flags	Details
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2016-08-02 20:22:40 PDT

Created attachment 285185 [details] Needs tests

Myles C. Maxfield

Comment 2 2016-08-02 20:23:29 PDT

<rdar://problem/25856238>

Jon Lee

Comment 3 2016-08-02 20:25:32 PDT

Comment on attachment 285185 [details] Needs tests View in context: https://bugs.webkit.org/attachment.cgi?id=285185&action=review > Source/WTF/ChangeLog:10 > + (WTF::cursorMovementIterator): Deleted. I think it would be worth to make brief statements about what the rules are supposed to define, if you can.

Myles C. Maxfield

Comment 4 2016-08-02 21:12:35 PDT

Created attachment 285191 [details] Patch

Alexey Proskuryakov

Comment 5 2016-08-02 21:49:16 PDT

Comment on attachment 285191 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285191&action=review > Source/WTF/ChangeLog:16 > + (WTF::cursorMovementIterator): Deleted. :-/

mitz

Comment 6 2016-08-02 21:51:41 PDT

Comment on attachment 285191 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285191&action=review > Source/WTF/ChangeLog:10 > + were causing flag emoji to have line breaking opportunities in thir “were” or “was”? typo: thir > Source/WTF/wtf/text/TextBreakIterator.cpp:169 > // This rule set is based on character-break iterator rules of ICU 4.0 > // <http://source.icu-project.org/repos/icu/icu/tags/release-4-0/source/data/brkitr/char.txt>. Is this comment still accurate?

Build Bot

Comment 7 2016-08-02 21:52:25 PDT

Comment on attachment 285191 [details] Patch Attachment 285191 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1802329 New failing tests: fast/text/flag-emoji-line-break.html

Build Bot

Comment 8 2016-08-02 21:52:30 PDT

Created attachment 285196 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 9 2016-08-02 21:55:53 PDT

Comment on attachment 285191 [details] Patch Attachment 285191 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1802337 New failing tests: fast/text/flag-emoji-line-break.html

Build Bot

Comment 10 2016-08-02 21:55:57 PDT

Created attachment 285197 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 11 2016-08-02 22:19:02 PDT

Comment on attachment 285191 [details] Patch Attachment 285191 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1802370 New failing tests: fast/text/flag-emoji-line-break.html

Build Bot

Comment 12 2016-08-02 22:19:07 PDT

Created attachment 285198 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5

Myles C. Maxfield

Comment 13 2016-08-02 22:23:09 PDT

Created attachment 285199 [details] Patch

Build Bot

Comment 14 2016-08-02 23:09:44 PDT

Comment on attachment 285199 [details] Patch Attachment 285199 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1802654 New failing tests: fast/text/flag-emoji-line-break.html

Build Bot

Comment 15 2016-08-02 23:09:49 PDT

Created attachment 285200 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 16 2016-08-02 23:12:47 PDT

Comment on attachment 285199 [details] Patch Attachment 285199 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1802661 New failing tests: fast/text/flag-emoji-line-break.html

Build Bot

Comment 17 2016-08-02 23:12:51 PDT

Created attachment 285201 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 18 2016-08-02 23:20:13 PDT

Comment on attachment 285199 [details] Patch Attachment 285199 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1802670 New failing tests: fast/text/flag-emoji-line-break.html

Build Bot

Comment 19 2016-08-02 23:20:17 PDT

Created attachment 285202 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5

Myles C. Maxfield

Comment 20 2016-08-02 23:36:37 PDT

Committed r204074: <http://trac.webkit.org/changeset/204074>

Note You need to log in before you can comment on or make changes to this bug.