| Summary: | Update breaking rules to match ICU 57 | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||
| Severity: | Normal | CC: | benjamin, buildbot, cdumez, cmarcelo, commit-queue, dino, jonlee, mitz, rniwa, simon.fraser, thorton, webkit-bug-importer | ||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||
|
Description
Myles C. Maxfield
2016-08-02 20:21:38 PDT
Created attachment 285185 [details]
Needs tests
Comment on attachment 285185 [details] Needs tests View in context: https://bugs.webkit.org/attachment.cgi?id=285185&action=review > Source/WTF/ChangeLog:10 > + (WTF::cursorMovementIterator): Deleted. I think it would be worth to make brief statements about what the rules are supposed to define, if you can. Created attachment 285191 [details]
Patch
Comment on attachment 285191 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285191&action=review > Source/WTF/ChangeLog:16 > + (WTF::cursorMovementIterator): Deleted. :-/ Comment on attachment 285191 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285191&action=review > Source/WTF/ChangeLog:10 > + were causing flag emoji to have line breaking opportunities in thir “were” or “was”? typo: thir > Source/WTF/wtf/text/TextBreakIterator.cpp:169 > // This rule set is based on character-break iterator rules of ICU 4.0 > // <http://source.icu-project.org/repos/icu/icu/tags/release-4-0/source/data/brkitr/char.txt>. Is this comment still accurate? Comment on attachment 285191 [details] Patch Attachment 285191 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1802329 New failing tests: fast/text/flag-emoji-line-break.html Created attachment 285196 [details]
Archive of layout-test-results from ews102 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 285191 [details] Patch Attachment 285191 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1802337 New failing tests: fast/text/flag-emoji-line-break.html Created attachment 285197 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 285191 [details] Patch Attachment 285191 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1802370 New failing tests: fast/text/flag-emoji-line-break.html Created attachment 285198 [details]
Archive of layout-test-results from ews113 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 285199 [details]
Patch
Comment on attachment 285199 [details] Patch Attachment 285199 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1802654 New failing tests: fast/text/flag-emoji-line-break.html Created attachment 285200 [details]
Archive of layout-test-results from ews101 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 285199 [details] Patch Attachment 285199 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1802661 New failing tests: fast/text/flag-emoji-line-break.html Created attachment 285201 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 285199 [details] Patch Attachment 285199 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1802670 New failing tests: fast/text/flag-emoji-line-break.html Created attachment 285202 [details]
Archive of layout-test-results from ews116 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Committed r204074: <http://trac.webkit.org/changeset/204074> |