Bug 160420 – [Fetch API] Fetch promises should not reject or resolve when ActiveDOMObjects are being stopped

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[youenn fablet]

This would lead to crashes, for instance in workers.

[youenn fablet]

Created attachment 285036 [details]
Patch

[youenn fablet]

Some crashes are remaining due to the assertion in WorkerThreadableLoader (loader being null and no callback called).

[Build Bot]

Comment on attachment 285036 [details]
Patch

Attachment 285036 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1794030

New failing tests:
imported/w3c/web-platform-tests/fetch/api/cors/cors-basic-worker.html
imported/w3c/web-platform-tests/fetch/api/cors/cors-cookies-worker.html

[Build Bot]

Created attachment 285041 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5

[Build Bot]

Comment on attachment 285036 [details]
Patch

Attachment 285036 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1794081

New failing tests:
imported/w3c/web-platform-tests/fetch/api/cors/cors-cookies-worker.html

[Build Bot]

Created attachment 285043 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Alex Christensen]

Comment on attachment 285036 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285036&action=review

watch the bots after landing this.  I wouldn't be surprised if more of the tests become flaky.

> LayoutTests/TestExpectations:-336
> -# Fetch Worker tests skipped until bug 156737 is resolved

Is this still going to be resolved?

> LayoutTests/TestExpectations:-338
> -imported/w3c/web-platform-tests/fetch/api/cors/cors-basic-worker.html [ Skip ]
> -imported/w3c/web-platform-tests/fetch/api/cors/cors-cookies-worker.html [ Skip ]

these seem to have failed on ews.

[youenn fablet]

Thanks for the review.

(In reply to comment #7)
> Comment on attachment 285036 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=285036&action=review
> 
> watch the bots after landing this.  I wouldn't be surprised if more of the
> tests become flaky.

Yes! I was thinking to activate this only for Release mode, but after some testing, it seems Debug is quite stable.

> > LayoutTests/TestExpectations:-336
> > -# Fetch Worker tests skipped until bug 156737 is resolved
> 
> Is this still going to be resolved?

I cannot reproduce it anymore 8-)

> > LayoutTests/TestExpectations:-338
> > -imported/w3c/web-platform-tests/fetch/api/cors/cors-basic-worker.html [ Skip ]
> > -imported/w3c/web-platform-tests/fetch/api/cors/cors-cookies-worker.html [ Skip ]
> 
> these seem to have failed on ews.

HTTPS tests on WK2 bots are failing due to invalid certificates.
But they pass on WK1.
I probably need to add specific expectations for these tests.

[youenn fablet]

Created attachment 285081 [details]
Patch for landing

[youenn fablet]

Created attachment 285083 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 285083 [details]
Patch for landing

Clearing flags on attachment: 285083

Committed r204020: <http://trac.webkit.org/changeset/204020>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.