Bug 160417

Summary: update a class extending null w.r.t the ES7 spec
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: adamk, benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ticaiolima, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 160392    
Attachments:
Description Flags
patch
keith_miller: review-
patch
none
patch
keith_miller: review+
patch for landing none

Saam Barati
Reported 2016-08-01 12:37:42 PDT
...
Attachments
patch (9.20 KB, patch)
2016-08-01 13:55 PDT, Saam Barati 		keith_miller: review-
DetailsFormatted DiffDiff
patch (32.04 KB, patch)
2016-08-02 13:25 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (31.73 KB, patch)
2016-08-02 13:52 PDT, Saam Barati 		keith_miller: review+
DetailsFormatted DiffDiff
patch for landing (33.12 KB, patch)
2016-08-02 16:02 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
GSkachkov
Comment 1 2016-08-01 12:43:44 PDT
*** Bug 160418 has been marked as a duplicate of this bug. ***
Saam Barati
Comment 2 2016-08-01 13:55:11 PDT
Created attachment 285039 [details] patch
Mark Lam
Comment 3 2016-08-01 13:59:07 PDT
Comment on attachment 285039 [details] patch r=me
Keith Miller
Comment 4 2016-08-01 14:00:27 PDT
Comment on attachment 285039 [details] patch I don't think this is right if you do: let foo = null; class A extends foo { } Shouldn't that also be a base class? https://tc39.github.io/ecma262/#sec-runtime-semantics-classdefinitionevaluation
Saam Barati
Comment 5 2016-08-01 14:28:55 PDT
(In reply to comment #4) > Comment on attachment 285039 [details] > patch > > I don't think this is right if you do: > > let foo = null; > class A extends foo { } > > Shouldn't that also be a base class? > https://tc39.github.io/ecma262/#sec-runtime-semantics- > classdefinitionevaluation Yup. My implementation is quite broken. This may be a bit annoying to refactor to make this work.
Saam Barati
Comment 6 2016-08-02 13:25:30 PDT
Created attachment 285130 [details] patch
Saam Barati
Comment 7 2016-08-02 13:52:07 PDT
Created attachment 285136 [details] patch
Keith Miller
Comment 8 2016-08-02 13:58:18 PDT
Comment on attachment 285136 [details] patch r=me.
Saam Barati
Comment 9 2016-08-02 16:02:15 PDT
Created attachment 285154 [details] patch for landing with updated test262 results.
WebKit Commit Bot
Comment 10 2016-08-02 18:29:36 PDT
Comment on attachment 285154 [details] patch for landing Clearing flags on attachment: 285154 Committed r204058: <http://trac.webkit.org/changeset/204058>
WebKit Commit Bot
Comment 11 2016-08-02 18:29:44 PDT
All reviewed patches have been landed. Closing bug.
Adam Klein
Comment 12 2017-01-25 10:20:36 PST
Heads-up that this has been reverted from ES2017 (and came in after ES2016) after a discussion at January's TC39 meeting. The spec revert was https://github.com/tc39/ecma262/commit/c57ef95c45a371f9c9485bb1c3881dbdc04524a2
Saam Barati
Comment 13 2017-03-07 11:01:54 PST
(In reply to comment #12) > Heads-up that this has been reverted from ES2017 (and came in after ES2016) > after a discussion at January's TC39 meeting. The spec revert was > https://github.com/tc39/ecma262/commit/ > c57ef95c45a371f9c9485bb1c3881dbdc04524a2 Thanks for the heads up. I filed: https://bugs.webkit.org/show_bug.cgi?id=169293 to fix this.
Note You need to log in before you can comment on or make changes to this bug.