Summary: | update a class extending null w.r.t the ES7 spec | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | adamk, benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ticaiolima, ysuzuki | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 160392 | ||||||||||||
Attachments: |
|
Description
Saam Barati
2016-08-01 12:37:42 PDT
*** Bug 160418 has been marked as a duplicate of this bug. *** Created attachment 285039 [details]
patch
Comment on attachment 285039 [details]
patch
r=me
Comment on attachment 285039 [details] patch I don't think this is right if you do: let foo = null; class A extends foo { } Shouldn't that also be a base class? https://tc39.github.io/ecma262/#sec-runtime-semantics-classdefinitionevaluation (In reply to comment #4) > Comment on attachment 285039 [details] > patch > > I don't think this is right if you do: > > let foo = null; > class A extends foo { } > > Shouldn't that also be a base class? > https://tc39.github.io/ecma262/#sec-runtime-semantics- > classdefinitionevaluation Yup. My implementation is quite broken. This may be a bit annoying to refactor to make this work. Created attachment 285130 [details]
patch
Created attachment 285136 [details]
patch
Comment on attachment 285136 [details]
patch
r=me.
Created attachment 285154 [details]
patch for landing
with updated test262 results.
Comment on attachment 285154 [details] patch for landing Clearing flags on attachment: 285154 Committed r204058: <http://trac.webkit.org/changeset/204058> All reviewed patches have been landed. Closing bug. Heads-up that this has been reverted from ES2017 (and came in after ES2016) after a discussion at January's TC39 meeting. The spec revert was https://github.com/tc39/ecma262/commit/c57ef95c45a371f9c9485bb1c3881dbdc04524a2 (In reply to comment #12) > Heads-up that this has been reverted from ES2017 (and came in after ES2016) > after a discussion at January's TC39 meeting. The spec revert was > https://github.com/tc39/ecma262/commit/ > c57ef95c45a371f9c9485bb1c3881dbdc04524a2 Thanks for the heads up. I filed: https://bugs.webkit.org/show_bug.cgi?id=169293 to fix this. |