Summary: | Freeze DOMHTMLTitleElement and DOMHTMLUListElement bindings | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, darin, sam | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Anders Carlsson
2016-08-01 12:19:01 PDT
Created attachment 285027 [details]
Patch
Attachment 285027 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/objc/DOMHTMLUListElement.mm:33: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/bindings/objc/DOMHTMLTitleElement.mm:32: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 2 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 285029 [details]
Patch
Comment on attachment 285029 [details]
Patch
rs=me
Attachment 285029 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/objc/DOMHTMLUListElement.mm:32: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebCore/bindings/objc/DOMHTMLTitleElement.mm:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 2 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #4) > Comment on attachment 285029 [details] > Patch > > rs=me ...though I don't approve of the license change. (In reply to comment #6) > (In reply to comment #4) > > Comment on attachment 285029 [details] > > Patch > > > > rs=me > > ...though I don't approve of the license change. Just matching what darin did to DOMHTMLTextAreaElement. Committed r203981: <http://trac.webkit.org/changeset/203981> |