Summary: | [GTK] GtkLauncher should be written in C | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alp Toker <alp> | ||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | Keywords: | Gtk | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Alp Toker
2007-11-18 09:44:00 PST
Created attachment 17365 [details]
Cleaned up C GtkLauncher, WIP
This is practically a rewrite, ported to C, using a toolbar instead of a menu, changing coding-style to something more common to C/GTK+ developers, and cleaning up old leftovers.
It still has globals. We can probably fix that later though.
Created attachment 17367 [details]
Ported to C
Note that this patch does not attempt to fix all issues with the code.
Created attachment 17368 [details]
Ported to C
Missed the ChangeLog in the previous patch.
(In reply to comment #3) > Created an attachment (id=17368) [edit] > Ported to C IIRC the // comment was only introduced in C99. M$ Visual Studio doesn't support it. If you want GtkLauncher to be portable you want to change the comments to be C comments. (In reply to comment #4) > (In reply to comment #3) > > Created an attachment (id=17368) [edit] > > Ported to C > > IIRC the // comment was only introduced in C99. M$ Visual Studio doesn't > support it. If you want GtkLauncher to be portable you want to change the > comments to be C comments. > Noted. Will fix this up before landing. Comment on attachment 17368 [details]
Ported to C
r=me
|