Bug 160374

Summary: [WebIDL] Enable strict type checking for operations' nullable parameters of wrapper types
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, commit-queue, darin, ggaren, manian, rniwa, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=160375
Bug Depends on:    
Bug Blocks: 160382    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-07-29 20:26:21 PDT
Enable strict type checking for operations' nullable parameters of wrapper types to comply with the Web IDL specification: - http://heycam.github.io/webidl/#es-nullable-type - http://heycam.github.io/webidl/#es-interface For such parameters, if the JS passes a value that is not null / undefined and does not have the expected wrapper type, then we now throw a TypeError instead of silently converting the value to null. This behavior is consistent with Chrome and Firefox. It also helps identify bugs in JavaScript code.
Attachments
Patch (32.00 KB, patch)
2016-07-29 20:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-07-29 20:38:48 PDT
Created attachment 284932 [details] Patch
youenn fablet
Comment 2 2016-07-30 01:15:32 PDT
Comment on attachment 284932 [details] Patch r=me
WebKit Commit Bot
Comment 3 2016-07-30 01:36:23 PDT
Comment on attachment 284932 [details] Patch Clearing flags on attachment: 284932 Committed r203941: <http://trac.webkit.org/changeset/203941>
WebKit Commit Bot
Comment 4 2016-07-30 01:36:29 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-02-21 12:51:36 PST
<rdar://problem/30637643>
Note You need to log in before you can comment on or make changes to this bug.