Bug 16037 – Scraps not displayed in Orkut due to unclosed <iframe> tag

• Component: Evangelism
• Status: RESOLVED FIXED

[Indrek Siitan]

As the summary says - the "scraps" in Orkut are not displayed at all - they appear in the source, but when rendering, the page is cut off after the title bar for the module.

[Matt Lilek]

Confirmed with r27879.

[David Kilzer (:ddkilzer)]

This issue is caused by an unclosed <iframe> tag in a document with an HTML 4.01 Transitional doctype:

  <div class="floatdiv" id="iframe_parent">
  <iframe id="scrap_extn_iframe" name="scrap_extn_iframe" src=""/>
  <!--[if lte IE 7.0]><iframe></iframe><![endif]-->
  </div>

Both Safari 2, Safari 3, ToT WebKit and Opera 9.24/9.50b leave the rest of the page blank because their parsers are looking for an </iframe> closing tag.

Firefox 2.0.0.9 and 3.0b2pre (Nov 18, 2007) both apparently find the </iframe> within the comment (per the coloration of their View Source window), which is highly suspect as well, but makes the page work for Firefox.

MSIE 7 apparently recognizes the self-closing <iframe/> tag (even though the document isn't XHTML), and of course parses the an additional <iframe></iframe> tags inside the VBScript.

Best fix would be to have Google fix the self-closing iframe to:

  <iframe id="scrap_extn_iframe" name="scrap_extn_iframe" src=""></iframe>

Marking this as an evangelism bug due to the above analysis.

[David Kilzer (:ddkilzer)]

Created attachment 17366 [details]
Test case

[David Storey]

We (Opera) have the same issue in out bts.  We agree it is a evangelism issue and FF are incorrect.  I'm activly seeking a Google Orkut contact to fix this.

[Pereira]

I'm a Googler and already contact Orkut Team to fix this.

[David Kilzer (:ddkilzer)]

(In reply to comment #5)
> I'm a Googler and already contact Orkut Team to fix this.

Thank you!

[David Storey]

One of my google contacts is looking for someone to fix it too.

[David Kilzer (:ddkilzer)]

(In reply to comment #7)
> One of my google contacts is looking for someone to fix it too.

Thanks, David!  I also cc-ed [e-mail] for this reason, although he's been quiet for a while now.

[David Storey]

I have:

"I talked to the product manager for Orkut and we have produced a fix for the issue which should be deployed in the next production push for Orkut (late November, early December).
 Please let me know if you have any further questions. "

We are getting tons of dupes on this (160 a day for Mini only).  They offered to do some sort of pre canned response in the mean time.

[David Kilzer (:ddkilzer)]

<rdar://problem/5721953>

[Eric Seidel (no email)]

So if this has been resolved on Orkut's side, the only thing left to decide is if this is proper HTML5 parsing or not.  If this is correct HTML5 parsing, then we can close this bug, if not, we'll need to fix it. :)

[Eric Seidel (no email)]

Our parsing looks correct:

http://james.html5.org/cgi-bin/parsetree/parsetree.py?source=++%3Cdiv%3E%0D%0A++%3Ciframe+style%3D%22display%3A+none%3B%22+src%3D%22%22%2F%3E%0D%0A++%3C%21--%5Bif+lte+IE+7.0%5D%3E%3Ciframe%3E%3C%2Fiframe%3E%3C%21%5Bendif%5D--%3E%0D%0A++%3C%2Fdiv%3E%0D%0A%3Cdiv%3E%3Cspan+style%3D%22color%3A+green%3B%22%3ESUCCESS%3C%2Fspan%3E+This+text+is+visible.%3C%2Fdiv%3E

http://software.hixie.ch/utilities/js/live-dom-viewer/?%20%20%3Cdiv%3E%0A%20%20%3Ciframe%20style%3D%22display%3A%20none%3B%22%20src%3D%22%22%2F%3E%0A%20%20%3C!--%5Bif%20lte%20IE%207.0%5D%3E%3Ciframe%3E%3C%2Fiframe%3E%3C!%5Bendif%5D--%3E%0A%20%20%3C%2Fdiv%3E%0A%3Cdiv%3E%3Cspan%20style%3D%22color%3A%20green%3B%22%3ESUCCESS%3C%2Fspan%3E%20This%20text%20is%20visible.%3C%2Fdiv%3E

Closing as invalid.

[David Kilzer (:ddkilzer)]

Actually(In reply to comment #12)
> Closing as invalid.

Actually, this bug was about an evangelism issue in Orkut (a Google property).  That bug seems to be fixed now, so I'm going to reopen this to reclose it as RESOLVED FIXED.