Summary: | [GTK] Implement missing WebCore::moveFile() using GLib functions | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adrian Perez <aperez> | ||||||||
Component: | WebKitGTK | Assignee: | Adrian Perez <aperez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, beidson, bugs-noreply, cgarcia, commit-queue, darin, mcatanzaro | ||||||||
Priority: | P2 | ||||||||||
Version: | Other | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 154553 | ||||||||||
Attachments: |
|
Description
Adrian Perez
2016-07-29 16:18:01 PDT
Created attachment 284914 [details]
Patch
Comment on attachment 284914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284914&action=review Thanks! > Source/WebCore/platform/glib/FileSystemGlib.cpp:381 > + return !g_rename(oldFilename.get(), oldFilename.get()); g_rename returns -1 in case of failure, I prefer to explicitly check that like all other functions in this file do. return rename != -1 Comment on attachment 284914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284914&action=review > Source/WebCore/ChangeLog:3 > + Implement WebCore::moveFile() using GLib. And please, use the actual bug title here. prepare-ChangeLog should do the right thing for you. Created attachment 284938 [details]
Patch
An updated patch is now uploaded. (In reply to comment #3) > Comment on attachment 284914 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=284914&action=review > > > Source/WebCore/ChangeLog:3 > > + Implement WebCore::moveFile() using GLib. > > And please, use the actual bug title here. prepare-ChangeLog should do the > right thing for you. I couldn't figure out how to make this work, but instead I have discovered that the following works like a charm: % webkit-patch prepare -g HEAD --update-changelogs <BUGID> prepare-ChangeLog -b <BUGID> (In reply to comment #6) > prepare-ChangeLog -b <BUGID> prepare-ChangeLog -g HEAD -b <BUGID> Comment on attachment 284938 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284938&action=review > Source/WebCore/platform/glib/FileSystemGlib.cpp:381 > + return g_rename(oldFilename.get(), oldFilename.get()) != -1; I didn't notice this in the previous patch, but you are using oldFilename in both arguments! :-D Created attachment 284971 [details]
Patch
(In reply to comment #8) > Comment on attachment 284938 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=284938&action=review > > > Source/WebCore/platform/glib/FileSystemGlib.cpp:381 > > + return g_rename(oldFilename.get(), oldFilename.get()) != -1; > > I didn't notice this in the previous patch, but you are using oldFilename in > both arguments! :-D Ouch, good catch! I have just uploaded a fixed version of the patch. Comment on attachment 284971 [details] Patch Clearing flags on attachment: 284971 Committed r203960: <http://trac.webkit.org/changeset/203960> All reviewed patches have been landed. Closing bug. |