Bug 160320

Summary: Parameters to Event.initEvent() should be mandatory
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, esprehn+autocc, kangil.han, kondapallykalyan, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://dom.spec.whatwg.org/#interface-eventtarget
Bug Depends on: 161162, 163967    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-07-28 14:55:51 PDT
Parameters to Event.initEvent() should be mandatory: - https://dom.spec.whatwg.org/#interface-event Firefox agrees with the specification. Chrome does not.
Attachments
Patch (14.26 KB, patch)
2016-07-28 14:58 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-07-28 14:58:18 PDT
Created attachment 284822 [details] Patch
Darin Adler
Comment 2 2016-07-28 15:55:20 PDT
Comment on attachment 284822 [details] Patch Who could possibly love those two mandatory booleans? Yuck.
Chris Dumez
Comment 3 2016-07-28 15:58:59 PDT
(In reply to comment #2) > Comment on attachment 284822 [details] > Patch > > Who could possibly love those two mandatory booleans? Yuck. Nowadays, people are supposed to use the Event constructors that take a dictionary instead of those init functions.
WebKit Commit Bot
Comment 4 2016-07-28 16:16:21 PDT
Comment on attachment 284822 [details] Patch Clearing flags on attachment: 284822 Committed r203848: <http://trac.webkit.org/changeset/203848>
WebKit Commit Bot
Comment 5 2016-07-28 16:16:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.