Bug 160311 – Web Inspector: Grid column resizer elements positioned incorrectly

• Component: Web Inspector
• Status: RESOLVED FIXED

[Matt Baker]

Summary:
Grid column resizer elements positioned incorrectly.

Steps to Reproduce:
1. Open Inspector
2. Switch to Timelines tab
3. Resize Inspector window horizontally
4. Switch to Network tab
  => Grid resizers are positioned incorrectly. Observable by hovering mouse near column boundaries.

[Radar WebKit Bug Importer]

<rdar://problem/27595586>

[Matt Baker]

Created attachment 284818 [details]
[Patch] Proposed Fix

[Blaze Burg]

Comment on attachment 284818 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=284818&action=review

> Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:238
> +        this._sizeDidChange = false;

In principle this seems like the right direction, but what if you switch again to another tab? It won't get that Resize layout. This might have to be a needsResizeLayout flag per tab.

[Matt Baker]

Comment on attachment 284818 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=284818&action=review

>> Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:238
>> +        this._sizeDidChange = false;
> 
> In principle this seems like the right direction, but what if you switch again to another tab? It won't get that Resize layout. This might have to be a needsResizeLayout flag per tab.

Very good point! Having a flag per tab should work.

[Timothy Hatcher]

Comment on attachment 284818 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=284818&action=review

>>> Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:238
>>> +        this._sizeDidChange = false;
>> 
>> In principle this seems like the right direction, but what if you switch again to another tab? It won't get that Resize layout. This might have to be a needsResizeLayout flag per tab.
> 
> Very good point! Having a flag per tab should work.

Yeah, I think this could be a symbol on each tabContentView that TabBrowser tracks.

[Matt Baker]

Created attachment 284891 [details]
[Patch] Proposed Fix

[Build Bot]

Comment on attachment 284891 [details]
[Patch] Proposed Fix

Attachment 284891 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1775539

New failing tests:
media/track/track-remove-quickly.html

[Build Bot]

Created attachment 284907 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5

[Matt Baker]

Created attachment 284968 [details]
[Patch] Proposed Fix

[Blaze Burg]

Comment on attachment 284968 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=284968&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:241
> +        }

Is this layout going to be redundant if we had to show/collapse some of the sidebar panels just above this branch?

[Matt Baker]

Comment on attachment 284968 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=284968&action=review

>> Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:241
>> +        }
> 
> Is this layout going to be redundant if we had to show/collapse some of the sidebar panels just above this branch?

Investigating before I cq+.

[Matt Baker]

I didn't observe any redundant layouts due to the patch. However trying different combinations of collapsed sidebars and split console when switching tabs, I found an existing case where switching tabs causes three layouts:

https://bugs.webkit.org/show_bug.cgi?id=160426

[WebKit Commit Bot]

Comment on attachment 284968 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 284968

Committed r203991: <http://trac.webkit.org/changeset/203991>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

Comment on attachment 284968 [details]
[Patch] Proposed Fix

Nice fix!