Summary: | Web Inspector: Grid column resizer elements positioned incorrectly | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Baker <mattbaker> | ||||||||||
Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Matt Baker
2016-07-28 13:24:24 PDT
Created attachment 284818 [details]
[Patch] Proposed Fix
Comment on attachment 284818 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=284818&action=review > Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:238 > + this._sizeDidChange = false; In principle this seems like the right direction, but what if you switch again to another tab? It won't get that Resize layout. This might have to be a needsResizeLayout flag per tab. Comment on attachment 284818 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=284818&action=review >> Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:238 >> + this._sizeDidChange = false; > > In principle this seems like the right direction, but what if you switch again to another tab? It won't get that Resize layout. This might have to be a needsResizeLayout flag per tab. Very good point! Having a flag per tab should work. Comment on attachment 284818 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=284818&action=review >>> Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:238 >>> + this._sizeDidChange = false; >> >> In principle this seems like the right direction, but what if you switch again to another tab? It won't get that Resize layout. This might have to be a needsResizeLayout flag per tab. > > Very good point! Having a flag per tab should work. Yeah, I think this could be a symbol on each tabContentView that TabBrowser tracks. Created attachment 284891 [details]
[Patch] Proposed Fix
Comment on attachment 284891 [details] [Patch] Proposed Fix Attachment 284891 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1775539 New failing tests: media/track/track-remove-quickly.html Created attachment 284907 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.5
Created attachment 284968 [details]
[Patch] Proposed Fix
Comment on attachment 284968 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=284968&action=review r=me > Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:241 > + } Is this layout going to be redundant if we had to show/collapse some of the sidebar panels just above this branch? Comment on attachment 284968 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=284968&action=review >> Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:241 >> + } > > Is this layout going to be redundant if we had to show/collapse some of the sidebar panels just above this branch? Investigating before I cq+. I didn't observe any redundant layouts due to the patch. However trying different combinations of collapsed sidebars and split console when switching tabs, I found an existing case where switching tabs causes three layouts: https://bugs.webkit.org/show_bug.cgi?id=160426 Comment on attachment 284968 [details] [Patch] Proposed Fix Clearing flags on attachment: 284968 Committed r203991: <http://trac.webkit.org/changeset/203991> All reviewed patches have been landed. Closing bug. Comment on attachment 284968 [details]
[Patch] Proposed Fix
Nice fix!
|