Bug 160311

Summary: Web Inspector: Grid column resizer elements positioned incorrectly
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Patch] Proposed Fix
none
[Patch] Proposed Fix
none
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
[Patch] Proposed Fix none

Description Matt Baker 2016-07-28 13:24:24 PDT
Summary:
Grid column resizer elements positioned incorrectly.

Steps to Reproduce:
1. Open Inspector
2. Switch to Timelines tab
3. Resize Inspector window horizontally
4. Switch to Network tab
  => Grid resizers are positioned incorrectly. Observable by hovering mouse near column boundaries.
Comment 1 Radar WebKit Bug Importer 2016-07-28 13:24:41 PDT
<rdar://problem/27595586>
Comment 2 Matt Baker 2016-07-28 14:24:19 PDT
Created attachment 284818 [details]
[Patch] Proposed Fix
Comment 3 BJ Burg 2016-07-29 11:13:46 PDT
Comment on attachment 284818 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=284818&action=review

> Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:238
> +        this._sizeDidChange = false;

In principle this seems like the right direction, but what if you switch again to another tab? It won't get that Resize layout. This might have to be a needsResizeLayout flag per tab.
Comment 4 Matt Baker 2016-07-29 11:36:46 PDT
Comment on attachment 284818 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=284818&action=review

>> Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:238
>> +        this._sizeDidChange = false;
> 
> In principle this seems like the right direction, but what if you switch again to another tab? It won't get that Resize layout. This might have to be a needsResizeLayout flag per tab.

Very good point! Having a flag per tab should work.
Comment 5 Timothy Hatcher 2016-07-29 11:37:35 PDT
Comment on attachment 284818 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=284818&action=review

>>> Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:238
>>> +        this._sizeDidChange = false;
>> 
>> In principle this seems like the right direction, but what if you switch again to another tab? It won't get that Resize layout. This might have to be a needsResizeLayout flag per tab.
> 
> Very good point! Having a flag per tab should work.

Yeah, I think this could be a symbol on each tabContentView that TabBrowser tracks.
Comment 6 Matt Baker 2016-07-29 12:59:47 PDT
Created attachment 284891 [details]
[Patch] Proposed Fix
Comment 7 Build Bot 2016-07-29 15:05:34 PDT
Comment on attachment 284891 [details]
[Patch] Proposed Fix

Attachment 284891 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1775539

New failing tests:
media/track/track-remove-quickly.html
Comment 8 Build Bot 2016-07-29 15:05:36 PDT
Created attachment 284907 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5
Comment 9 Matt Baker 2016-07-31 12:15:51 PDT
Created attachment 284968 [details]
[Patch] Proposed Fix
Comment 10 BJ Burg 2016-08-01 11:28:25 PDT
Comment on attachment 284968 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=284968&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:241
> +        }

Is this layout going to be redundant if we had to show/collapse some of the sidebar panels just above this branch?
Comment 11 Matt Baker 2016-08-01 13:13:42 PDT
Comment on attachment 284968 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=284968&action=review

>> Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:241
>> +        }
> 
> Is this layout going to be redundant if we had to show/collapse some of the sidebar panels just above this branch?

Investigating before I cq+.
Comment 12 Matt Baker 2016-08-01 15:10:34 PDT
I didn't observe any redundant layouts due to the patch. However trying different combinations of collapsed sidebars and split console when switching tabs, I found an existing case where switching tabs causes three layouts:

https://bugs.webkit.org/show_bug.cgi?id=160426
Comment 13 WebKit Commit Bot 2016-08-01 15:32:20 PDT
Comment on attachment 284968 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 284968

Committed r203991: <http://trac.webkit.org/changeset/203991>
Comment 14 WebKit Commit Bot 2016-08-01 15:32:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 15 Joseph Pecoraro 2016-08-10 23:38:45 PDT
Comment on attachment 284968 [details]
[Patch] Proposed Fix

Nice fix!