Bug 160301

Summary: Move parsing of operator length attributes to MathMLOperatorElement
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: MathMLAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, bfulgham, commit-queue, darin, dbarton, esprehn+autocc, glenn, kondapallykalyan, rego
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 160190    
Bug Blocks: 156537, 160336    
Attachments:
Description Flags
Patch (WIP)
none
Patch (applies after bugs 160241, 160245, 160239 and 160190)
none
Patch (applies after bug 160190)
darin: review+
Patch none

Frédéric Wang (:fredw)
Reported 2016-07-28 10:36:33 PDT
Created attachment 284787 [details] Patch (WIP) Yet another step toward bug 156537. This covers: - lspace - rspace - minsize - maxsize
Attachments
Patch (WIP) (6.89 KB, patch)
2016-07-28 10:36 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (applies after bugs 160241, 160245, 160239 and 160190) (12.46 KB, patch)
2016-07-29 01:42 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (applies after bug 160190) (12.44 KB, patch)
2016-08-02 06:26 PDT, Frédéric Wang (:fredw) 		darin: review+
DetailsFormatted DiffDiff
Patch (12.41 KB, patch)
2016-08-02 11:56 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2016-07-29 01:42:21 PDT
Created attachment 284854 [details] Patch (applies after bugs 160241, 160245, 160239 and 160190)
Darin Adler
Comment 2 2016-07-31 21:42:59 PDT
Comment on attachment 284854 [details] Patch (applies after bugs 160241, 160245, 160239 and 160190) This pattern of having a "dirty" flag in various values is not a good one. Because it means we have an incorrect value that we could read and we have to be careful not to write code that looks at it without looking at the dirty flag first. A much better pattern is to use Optional and set to null when the value needs to be recomputed. This ties together the dirty flag with the value it guards in a more explicit way.
Frédéric Wang (:fredw)
Comment 3 2016-08-01 08:10:21 PDT
(In reply to comment #2) > This pattern of having a "dirty" flag in various values is not a good one. > Because it means we have an incorrect value that we could read and we have > to be careful not to write code that looks at it without looking at the > dirty flag first. A much better pattern is to use Optional and set to null > when the value needs to be recomputed. This ties together the dirty flag > with the value it guards in a more explicit way. OK, I've opened bug 160400 and also updated the first patch in the series (bug 160239) to use Optional<T>. So let's consider these patches first and I'll rebase all the patches afterwards.
Frédéric Wang (:fredw)
Comment 4 2016-08-02 06:26:48 PDT
Created attachment 285104 [details] Patch (applies after bug 160190)
Frédéric Wang (:fredw)
Comment 5 2016-08-02 11:56:44 PDT
Created attachment 285122 [details] Patch
Frédéric Wang (:fredw)
Comment 6 2016-08-02 12:55:22 PDT
Committed r204037: <http://trac.webkit.org/changeset/204037>
Note You need to log in before you can comment on or make changes to this bug.