|Product:||WebKit||Reporter:||Alp Toker <alp>|
|Severity:||Major||CC:||darin, ggaren, mrowe|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
|Bug Blocks:||15687, 16032|
Description Alp Toker 2007-11-17 12:08:59 PST
Comment 1 Darin Adler 2007-11-17 15:18:53 PST
Comment 2 Mark Rowe (bdash) 2007-11-17 15:41:56 PST
Comment 3 Alp Toker 2007-11-17 15:43:32 PST
Comment 4 Mark Rowe (bdash) 2007-11-17 15:50:57 PST
Comment 5 Alp Toker 2007-11-17 16:18:14 PST
Comment 6 Mark Rowe (bdash) 2007-11-17 21:54:40 PST
Comment 7 Alp Toker 2007-11-18 10:22:01 PST
Comment 8 Mark Rowe (bdash) 2007-11-18 10:30:03 PST
Why would "code written on non-Mac which does not use or expect to pull in CF break when you attempt to compile it on a Mac"?
Comment 9 Alp Toker 2007-11-18 13:51:05 PST
(In reply to comment #8) > Why would "code written on non-Mac which does not use or expect to pull in CF > break when you attempt to compile it on a Mac"? > It seemed to me that implicitly pulling CF headers into an application using GLib or Qt may cause trouble. Perhaps it wouldn't. My understanding of best portability practices is that it's good to avoid this kind of situation.
Comment 10 Alp Toker 2007-11-25 18:18:06 PST
Holger mentioned that C++-style comments "//" aren't accepted by some C compilers (he mentioned MSVC but I don't remember that being the case). There are some comments like this in the API headers. If this turns out to be an issue, we might want to change those comments to increase portability. Does anyone have the facts on this?
Comment 11 Alp Toker 2008-01-07 10:22:15 PST
Comment 12 Darin Adler 2008-01-07 10:31:08 PST
Comment 14 Timothy Hatcher 2008-01-07 12:21:47 PST
Comment 15 Timothy Hatcher 2008-01-07 12:22:41 PST
Comment 16 Alp Toker 2008-01-07 12:35:50 PST
Comment 17 Darin Adler 2008-01-07 12:40:13 PST
Comment 18 Alp Toker 2008-01-07 13:04:39 PST
Nice build fixing. Thanks timothy and aroben. I wonder though if the Mac build should use ForwardingHeaders for the JSC API like the GTK+ build. This would help keep minidom buildable out-of-tree against the system-installed SDK (since it's a nice code sample for people learning the API to try building themselves).