Bug 160270

Summary: Sub should be a Math IC
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, ossy, sukolsak, ticaiolima, ysuzuki
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
patch none

Saam Barati
Reported 2016-07-27 14:31:26 PDT
...
Attachments
WIP (18.40 KB, patch)
2016-07-27 15:42 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (24.77 KB, patch)
2016-07-28 15:26 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-07-27 15:42:19 PDT
Created attachment 284738 [details] WIP I want to take some data on old vs new. But I think this patch should work
WebKit Commit Bot
Comment 2 2016-07-27 15:45:18 PDT
Attachment 284738 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/jit/JITSubGenerator.cpp:51: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/jit/JITSubGenerator.cpp:53: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/jit/JITSubGenerator.cpp:56: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/jit/JITSubGenerator.cpp:60: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:1713: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 5 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 3 2016-07-28 15:26:23 PDT
Created attachment 284823 [details] patch
Mark Lam
Comment 4 2016-08-01 09:47:08 PDT
Comment on attachment 284823 [details] patch r=me
WebKit Commit Bot
Comment 5 2016-08-01 11:49:32 PDT
Comment on attachment 284823 [details] patch Clearing flags on attachment: 284823 Committed r203979: <http://trac.webkit.org/changeset/203979>
WebKit Commit Bot
Comment 6 2016-08-01 11:49:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.