Bug 160258

Summary: First parameter to Document.execCommand() / queryCommand*() should be mandatory
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: HTML EditingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, dbates, esprehn+autocc, kangil.han, kondapallykalyan, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://w3c.github.io/editing/execCommand.html
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-07-27 10:43:39 PDT
First parameter to Document.execCommand() / queryCommand*() should be mandatory: - https://w3c.github.io/editing/execCommand.html Firefox and Chrome agree with the specification.
Attachments
Patch (20.83 KB, patch)
2016-07-27 10:46 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-07-27 10:46:08 PDT
Created attachment 284708 [details] Patch
Darin Adler
Comment 2 2016-07-27 10:54:33 PDT
Comment on attachment 284708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284708&action=review > Source/WebCore/dom/Document.idl:143 > + // FIXME: The default value for the last parameter should be the empty string. What prevents us from making this change at this time? Or are you just going to do this in a separate patch for better future bisecting?
Chris Dumez
Comment 3 2016-07-27 11:07:07 PDT
Comment on attachment 284708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284708&action=review >> Source/WebCore/dom/Document.idl:143 >> + // FIXME: The default value for the last parameter should be the empty string. > > What prevents us from making this change at this time? Or are you just going to do this in a separate patch for better future bisecting? It needs further investigation because I believe Chrome matches the spec but Firefox does not.
WebKit Commit Bot
Comment 4 2016-07-27 11:28:35 PDT
Comment on attachment 284708 [details] Patch Clearing flags on attachment: 284708 Committed r203784: <http://trac.webkit.org/changeset/203784>
WebKit Commit Bot
Comment 5 2016-07-27 11:28:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.