Bug 160202

Summary: Second parameter to Range.isPointInRange() / comparePoint() should be mandatory
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cdumez, cfleizach, commit-queue, dmazzoni, esprehn+autocc, jcraig, jdiggs, kangil.han, kondapallykalyan, mario, rniwa, samuel_white
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://dom.spec.whatwg.org/#interface-range
See Also: https://bugs.webkit.org/show_bug.cgi?id=160184
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews112 for mac-yosemite
none
Patch
none
Patch none

Chris Dumez
Reported 2016-07-26 10:25:22 PDT
Second parameter to Range.isPointInRange() / comparePoint() should be mandatory and be of type "unsigned long": - https://dom.spec.whatwg.org/#interface-range Firefox and Chrome agree with the specification.
Attachments
Patch (28.04 KB, patch)
2016-07-26 10:51 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews112 for mac-yosemite (646.25 KB, application/zip)
2016-07-26 11:38 PDT, Build Bot 		no flags
Details
Patch (28.92 KB, patch)
2016-07-26 11:46 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (28.94 KB, patch)
2016-07-26 12:03 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-07-26 10:51:40 PDT
Created attachment 284604 [details] Patch
Chris Dumez
Comment 2 2016-07-26 11:23:26 PDT
I will investigate the failures for the debug builds.
Build Bot
Comment 3 2016-07-26 11:38:46 PDT
Comment on attachment 284604 [details] Patch Attachment 284604 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1757326 Number of test failures exceeded the failure limit.
Build Bot
Comment 4 2016-07-26 11:38:52 PDT
Created attachment 284610 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
Chris Dumez
Comment 5 2016-07-26 11:46:18 PDT
Created attachment 284611 [details] Patch
Chris Dumez
Comment 6 2016-07-26 12:03:23 PDT
Created attachment 284615 [details] Patch
WebKit Commit Bot
Comment 7 2016-07-26 13:55:37 PDT
Comment on attachment 284615 [details] Patch Clearing flags on attachment: 284615 Committed r203733: <http://trac.webkit.org/changeset/203733>
WebKit Commit Bot
Comment 8 2016-07-26 13:55:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.