Bug 16018

Summary: build bustage when building on debian 4.0
Product: WebKit Reporter: doug turner <dougt>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch which uses gtk_get_default_language
none
patch 2 w/ change log alp: review+

doug turner
Reported 2007-11-16 14:03:00 PST
on a stock install of debian 4.0, my build is failing in: WebCore/platform/gtk/Language.cpp Apparently, pango_language_get_default() is not defined by the shipping version of pango. this function was introduced in Pango-1.15.2 or maybe 1.16. we can just replace the old pango_ call with the gtk_ one, or we can use a version check macro to choose one conditionally. patch coming up that replaces the pango call.
Attachments
patch which uses gtk_get_default_language (673 bytes, patch)
2007-11-16 14:04 PST, doug turner 		no flags
DetailsFormatted DiffDiff
patch 2 w/ change log (1.23 KB, patch)
2007-11-16 14:17 PST, doug turner 		alp: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
doug turner
Comment 1 2007-11-16 14:04:37 PST
Created attachment 17317 [details] patch which uses gtk_get_default_language Note that I removed the static string as the docs say that the value of gtk_get_default_language can change over the lifetime of the application. I am worry about this being a perf hit, so we should watch carefully after this lands.
doug turner
Comment 2 2007-11-16 14:17:38 PST
Created attachment 17319 [details] patch 2 w/ change log
Alp Toker
Comment 3 2007-11-16 14:23:25 PST
Comment on attachment 17319 [details] patch 2 w/ change log Looks great. ChangeLog entry could be slightly more descriptive, but I can fix that up before landing it.
Alp Toker
Comment 4 2007-11-16 14:27:29 PST
Landed in r27858. Thanks!
Note You need to log in before you can comment on or make changes to this bug.