Bug 160141

Summary: RenderBox::haveSameDirection is used only by table items.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

zalan
Reported 2016-07-23 20:22:16 PDT
It does not need to be on RenderBox.
Attachments
Patch (10.37 KB, patch)
2016-07-23 20:38 PDT, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2016-07-23 20:38:16 PDT
Created attachment 284434 [details] Patch
Simon Fraser (smfr)
Comment 2 2016-07-23 22:32:04 PDT
Comment on attachment 284434 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284434&action=review > Source/WebCore/rendering/RenderTable.h:381 > +inline bool isDirectionSame(const RenderBox* tableItem, const RenderBox* otherTableItem) { return tableItem && otherTableItem ? tableItem->style().direction() == otherTableItem->style().direction() : true; } Why not use references? The old code never null-checked.
WebKit Commit Bot
Comment 3 2016-07-25 19:17:01 PDT
Comment on attachment 284434 [details] Patch Clearing flags on attachment: 284434 Committed r203705: <http://trac.webkit.org/changeset/203705>
WebKit Commit Bot
Comment 4 2016-07-25 19:17:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.