Bug 160140

Summary: [iOS] Make sure we call the ProcessAssertion invalidation handler on the main thread
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, barraclough, ddkilzer, sam, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Chris Dumez
Reported 2016-07-23 20:13:47 PDT
Make sure we call the ProcessAssertion invalidation handler on the main thread. BKSProcessAssertion calls our invalidation handler on a background thread which leads to thread safety problems and crashes.
Attachments
Patch (5.60 KB, patch)
2016-07-23 20:32 PDT, Chris Dumez 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-07-23 20:14:04 PDT
<rdar://problem/27399998>
Chris Dumez
Comment 2 2016-07-23 20:32:52 PDT
Created attachment 284433 [details] Patch
Darin Adler
Comment 3 2016-07-25 09:53:51 PDT
Comment on attachment 284433 [details] Patch Still need to update the iOS simulator half of ProcessAssertionIOS.mm to use WTF::Function instead of std::function.
Chris Dumez
Comment 4 2016-07-25 09:58:35 PDT
Committed r203687: <http://trac.webkit.org/changeset/203687>
Note You need to log in before you can comment on or make changes to this bug.