Bug 160134

Summary:

Clean up RuntimeEnabledFeatures

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

NEW

Severity:

Normal

CC:

buildbot, dino, rniwa, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews103 for mac-yosemite	none
Archive of layout-test-results from ews106 for mac-yosemite-wk2	none
Archive of layout-test-results from ews113 for mac-yosemite	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Patch	none
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews106 for mac-yosemite-wk2	none
Archive of layout-test-results from ews117 for mac-yosemite	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none

Simon Fraser (smfr)

Reported 2016-07-23 15:49:22 PDT

Clean up RuntimeEnabledFeatures

Attachments
Patch (3.75 KB, patch) 2016-07-23 15:52 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-yosemite (639.93 KB, application/zip) 2016-07-23 16:29 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (781.93 KB, application/zip) 2016-07-23 16:32 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews113 for mac-yosemite (650.43 KB, application/zip) 2016-07-23 16:38 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (583.33 KB, application/zip) 2016-07-23 16:39 PDT, Build Bot	no flags	Details
Patch (5.25 KB, patch) 2016-07-23 20:10 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.28 MB, application/zip) 2016-07-23 20:57 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.34 MB, application/zip) 2016-07-23 21:03 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-yosemite (1.46 MB, application/zip) 2016-07-23 21:07 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (906.36 KB, application/zip) 2016-07-23 21:07 PDT, Build Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2016-07-23 15:52:29 PDT

Created attachment 284423 [details] Patch

Build Bot

Comment 2 2016-07-23 16:29:04 PDT

Comment on attachment 284423 [details] Patch Attachment 284423 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1741826 Number of test failures exceeded the failure limit.

Build Bot

Comment 3 2016-07-23 16:29:07 PDT

Created attachment 284424 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 4 2016-07-23 16:32:50 PDT

Comment on attachment 284423 [details] Patch Attachment 284423 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1741839 Number of test failures exceeded the failure limit.

Build Bot

Comment 5 2016-07-23 16:32:53 PDT

Created attachment 284425 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-07-23 16:38:02 PDT

Comment on attachment 284423 [details] Patch Attachment 284423 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1741835 Number of test failures exceeded the failure limit.

Build Bot

Comment 7 2016-07-23 16:38:04 PDT

Created attachment 284426 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 8 2016-07-23 16:39:04 PDT

Comment on attachment 284423 [details] Patch Attachment 284423 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1741836 Number of test failures exceeded the failure limit.

Build Bot

Comment 9 2016-07-23 16:39:07 PDT

Created attachment 284427 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.5

Simon Fraser (smfr)

Comment 10 2016-07-23 20:10:01 PDT

Created attachment 284432 [details] Patch

Build Bot

Comment 11 2016-07-23 20:57:43 PDT

Comment on attachment 284432 [details] Patch Attachment 284432 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1742890 New failing tests: webgl/webgl2-rendering-context-obtain.html imported/w3c/web-platform-tests/html/dom/interfaces.html js/dom/dom-static-property-for-in-iteration.html imported/w3c/web-platform-tests/html/dom/reflection-text.html

Build Bot

Comment 12 2016-07-23 20:57:47 PDT

Created attachment 284435 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 13 2016-07-23 21:03:10 PDT

Comment on attachment 284432 [details] Patch Attachment 284432 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1742901 New failing tests: imported/w3c/web-platform-tests/html/dom/reflection-text.html js/dom/dom-static-property-for-in-iteration.html http/tests/security/anchor-download-allow-data.html webgl/webgl2-rendering-context-obtain.html fast/dom/HTMLAnchorElement/anchor-nodownload-set.html http/tests/security/anchor-download-allow-sameorigin.html imported/w3c/web-platform-tests/html/dom/interfaces.html fast/dom/HTMLAnchorElement/anchor-download.html

Build Bot

Comment 14 2016-07-23 21:03:14 PDT

Created attachment 284437 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 15 2016-07-23 21:07:25 PDT

Comment on attachment 284432 [details] Patch Attachment 284432 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1742900 New failing tests: webgl/webgl2-rendering-context-obtain.html js/dom/dom-static-property-for-in-iteration.html

Build Bot

Comment 16 2016-07-23 21:07:29 PDT

Created attachment 284438 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 17 2016-07-23 21:07:36 PDT

Comment on attachment 284432 [details] Patch Attachment 284432 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1742899 New failing tests: imported/w3c/web-platform-tests/html/dom/reflection-text.html

Build Bot

Comment 18 2016-07-23 21:07:39 PDT

Created attachment 284439 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.5

Simon Fraser (smfr)

Comment 19 2016-07-23 21:26:58 PDT

Comment on attachment 284432 [details] Patch There's a lot of confusion about what is true for these settings. Some things like m_isWebGL2Enabled were not touched by reset(), so left with their values that come from platform preferences (which DRT and WTR hardcode to be enabled). I think we need to decide what the default values in RuntimeEnabledFeatures mean, and how they interact with platform preferences, and get reset between tests.

Simon Fraser (smfr)

Comment 20 2016-07-23 21:27:16 PDT

(In reply to comment #19) > Comment on attachment 284432 [details] > Patch > > There's a lot of confusion about what is true for these settings. ...what is truth

Note You need to log in before you can comment on or make changes to this bug.