|Summary:||[GTK] Tests failing after enabling ThreadedCompositor|
|Product:||WebKit||Reporter:||Michael Catanzaro <mcatanzaro>|
|Component:||WebKitGTK||Assignee:||Charlie Turner <cturner>|
|Severity:||Normal||CC:||bugs-noreply, cgarcia, commit-queue, cturner, mcatanzaro, pnormand|
|Bug Depends on:||174982, 175881|
Description Michael Catanzaro 2016-07-23 07:55:02 PDT
Using this bug to track test failures caused by the switch to enable ThreadedCompositor. No patches in this bug; this bug is just for tracking test expectations.
Comment 1 Michael Catanzaro 2016-07-23 08:06:33 PDT
New flaky crashes (excluding bug #160078): webkit.org/b/160119 media/media-fullscreen-inline.html [ Crash Pass ] webkit.org/b/160119 media/video-playbackrate.html [ Crash Pass ]
Comment 2 Michael Catanzaro 2016-07-23 09:15:17 PDT
(In reply to comment #1) > New flaky crashes (excluding bug #160078): > > webkit.org/b/160119 media/media-fullscreen-inline.html [ Crash Pass ] > webkit.org/b/160119 media/video-playbackrate.html [ Crash Pass ] Well, more than this. There's enough that I think it's simplest to use just the TestExpectations file (and separate bugs) to track all of these, rather than mentioning all bugs here. Let's just leave this bug open until the last tests against it are removed from the TestExpectations file.
Comment 3 Michael Catanzaro 2016-07-23 14:42:20 PDT
Some of the tests that crash flakily with X window system errors have crashed only once ever. For example: imported/blink/transforms/inline-transform-and-clipping-roots.html media/broken-video.html media/track/audio/audio-track-mkv-vorbis-enabled.html media/track/track-css-matching-timestamps.html Most likely something somewhere is triggering X window system errors and these tests just got unlucky.
Comment 4 Michael Catanzaro 2016-09-07 08:24:49 PDT
I removed most of the tests that were flaky from the expectations for this bug, leaving only the tests that consistently fail or the tests that crash or time out. We now have roughly 65 tests marked against this bug. This is not so bad. Some of these are probably even fixed already, and we just need to check. One concerning exception are the HTML5 media tests, which account for 23 of the broken tests. This is worth investigating.
Comment 6 WebKit Commit Bot 2017-07-11 12:25:57 PDT
Comment on attachment 315121 [details] Patch Clearing flags on attachment: 315121 Committed r219353: <http://trac.webkit.org/changeset/219353>
Comment 7 WebKit Commit Bot 2017-07-11 12:25:58 PDT
All reviewed patches have been landed. Closing bug.
Comment 8 Charlie Turner 2017-07-11 12:40:36 PDT
Was a gardening commit, reopening.