Bug 160078

Summary: [Coordinated Graphics] Test imported/blink/svg/custom/svg-image-layers-crash.html crashes
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, dino, gyuyoung.kim, thorton
Priority: P2 Keywords: LayoutTestFailure
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.chromium.org/p/chromium/issues/detail?id=266542
Bug Depends on:    
Bug Blocks: 154066    
Attachments:
Description Flags
Patch none

Description Carlos Garcia Campos 2016-07-22 01:40:22 PDT 
The test is marked as crash in EFL test expectations, because it seems to only crash with coordinated graphics. The thing is that the fix for this in blink seems to work, so we could just merge it in WebKit.
Comment 1 Carlos Garcia Campos 2016-07-22 01:48:59 PDT 
Created attachment 284317 [details]
Patch
Comment 2 Michael Catanzaro 2016-07-22 07:58:20 PDT 
Comment on attachment 284317 [details]
Patch

Well this is hardly a real fix, as we've already agreed to remove the ability to disable AC mode, this is just going to break again in the future. But of course it's best to not crash in the meantime....
Comment 3 Carlos Garcia Campos 2016-07-22 08:23:02 PDT 
(In reply to comment #2)
> Comment on attachment 284317 [details]
> Patch
> 
> Well this is hardly a real fix, as we've already agreed to remove the
> ability to disable AC mode, this is just going to break again in the future.
> But of course it's best to not crash in the meantime....

No no no, this happens with the threaded compositor that uses coordinated graphics and has accelerated compositing always enabled. We can still disable accelerated compositing setting in such case. Try running poster circle with WEBKIT_DISABLE_COMPOSITING_MODE, for example, with current trunk that has threaded compositor enabled.
Comment 4 Michael Catanzaro 2016-07-23 08:04:12 PDT 
Comment on attachment 284317 [details]
Patch

cq+ since I'm gardening and want this failure to disappear.
Comment 5 WebKit Commit Bot 2016-07-23 08:24:55 PDT 
Comment on attachment 284317 [details]
Patch

Clearing flags on attachment: 284317

Committed r203643: <http://trac.webkit.org/changeset/203643>
Comment 6 WebKit Commit Bot 2016-07-23 08:25:00 PDT 
All reviewed patches have been landed.  Closing bug.