Bug 160058
| Summary: | REGRESSION(r203440): JSC Testing time on ARM devices increased by 50% | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Saboff <msaboff> |
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | ap, ossy |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 159929 | ||
Michael Saboff
From https://bugs.webkit.org/show_bug.cgi?id=159929#c13:
Just a quick statistic:
- AArch64, ARMv7 Thumb2, ARMv7 Traditional and GTK ARM bots
now run 36.000 tests instead of 20.000, the extra 16.000 tests
don't add anything for testing, they are simply duplicated tests.
- runtime on AArch64 bot: 73 mins -> 112 mins
- runtime on ARMv7 Thumb2 bot: 109 mins -> 168 mins
- runtime on ARMv7 ARM traditional bot: 186 mins -> 260 mins
- runtime on ARM GTK (Thumb2) bot: 48 mins -> 76 mins
"So, maybe rather than preserving this broken feature, we should create
something that (a) acknowledges the fact that the FTL is the default on those
platforms that support it and (b) avoids running no-ftl tests on precisely those
platforms that don't have FTL."
OK, so when do you plan to fix this completely broken jsc-stress-tests
script not to run extra tests on 32-bit platforms which won't have
FTL JIT ever in the future? It's not fair to increase the test runtime
on 32-bit platforms just to paint your extra slow debug bot green.
----
Apple Internal ARM bots are now timing out after 2 hours.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Csaba Osztrogonác
I already fixed it in bug160033, just need review.
*** This bug has been marked as a duplicate of bug 160033 ***