Bug 160039

Summary: Fix null handling for HTMLImageElement.border
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, commit-queue, darin, dbates, esprehn+autocc, gyuyoung.kim, kondapallykalyan, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://html.spec.whatwg.org/#HTMLImageElement-partial
See Also: https://bugs.webkit.org/show_bug.cgi?id=160040
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews123 for ios-simulator-wk2
none
Patch none

Chris Dumez
Reported 2016-07-21 12:16:19 PDT
Fix null handling for HTMLImageElement.border to match the specification: - https://html.spec.whatwg.org/#HTMLImageElement-partial We are supposed to treat null as the empty string. Both Firefox and Chrome agree with the specification.
Attachments
Patch (6.20 KB, patch)
2016-07-21 12:30 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (789.88 KB, application/zip)
2016-07-21 13:29 PDT, Build Bot 		no flags
Details
Patch (7.38 KB, patch)
2016-07-21 13:30 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-07-21 12:30:39 PDT
Created attachment 284245 [details] Patch
Build Bot
Comment 2 2016-07-21 13:28:56 PDT
Comment on attachment 284245 [details] Patch Attachment 284245 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1727210 New failing tests: imported/w3c/web-platform-tests/html/dom/reflection-embedded.html
Build Bot
Comment 3 2016-07-21 13:29:00 PDT
Created attachment 284255 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.5
Chris Dumez
Comment 4 2016-07-21 13:30:51 PDT
Created attachment 284256 [details] Patch
Chris Dumez
Comment 5 2016-07-21 14:10:44 PDT
Comment on attachment 284256 [details] Patch Clearing flags on attachment: 284256 Committed r203523: <http://trac.webkit.org/changeset/203523>
Chris Dumez
Comment 6 2016-07-21 14:10:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.