Bug 160030

Summary:

The 2 first parameters to DOMImplementation.createDocument() should be mandatory

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, buildbot, cdumez, commit-queue, darin, dbates, esprehn+autocc, kangil.han, kondapallykalyan, rniwa, sam

Priority:

Keywords:

WebExposed

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Archive of layout-test-results from ews116 for mac-yosemite	none
Archive of layout-test-results from ews103 for mac-yosemite	none
Patch	none
Patch	none

Chris Dumez

Reported 2016-07-21 10:24:50 PDT

The 2 first parameters to Document.createDocument() should be mandatory as per the specification: - https://dom.spec.whatwg.org/#domimplementation Firefox and Chrome both agree with the specification. However, those parameters are currently marked as optional in WebKit.

Attachments
Patch (12.43 KB, patch) 2016-07-21 10:34 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (640.72 KB, application/zip) 2016-07-21 11:35 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-yosemite (1.42 MB, application/zip) 2016-07-21 11:36 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews103 for mac-yosemite (950.05 KB, application/zip) 2016-07-21 11:39 PDT, Build Bot	no flags	Details
Patch (13.08 KB, patch) 2016-07-21 11:39 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (13.08 KB, patch) 2016-07-21 11:42 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2016-07-21 10:34:25 PDT

Created attachment 284228 [details] Patch

Build Bot

Comment 2 2016-07-21 11:35:41 PDT

Comment on attachment 284228 [details] Patch Attachment 284228 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1726376 New failing tests: svg/animations/smil-element-target-crash-main.html

Build Bot

Comment 3 2016-07-21 11:35:44 PDT

Created attachment 284233 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.5

Build Bot

Comment 4 2016-07-21 11:36:01 PDT

Comment on attachment 284228 [details] Patch Attachment 284228 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1726380 New failing tests: svg/animations/smil-element-target-crash-main.html

Build Bot

Comment 5 2016-07-21 11:36:04 PDT

Created attachment 284234 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-07-21 11:39:12 PDT

Comment on attachment 284228 [details] Patch Attachment 284228 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1726457 New failing tests: svg/animations/smil-element-target-crash-main.html

Build Bot

Comment 7 2016-07-21 11:39:16 PDT

Created attachment 284236 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5

Chris Dumez

Comment 8 2016-07-21 11:39:25 PDT

Created attachment 284237 [details] Patch

Chris Dumez

Comment 9 2016-07-21 11:42:58 PDT

Created attachment 284238 [details] Patch

WebKit Commit Bot

Comment 10 2016-07-21 12:05:34 PDT

Comment on attachment 284238 [details] Patch Clearing flags on attachment: 284238 Committed r203517: <http://trac.webkit.org/changeset/203517>

WebKit Commit Bot

Comment 11 2016-07-21 12:05:39 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.