Bug 160021

Summary: Clarify testing mode names in run-jsc-stress-tests
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, keith_miller, lforschler, mark.lam, msaboff, ossy, saam
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 160033    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Csaba Osztrogonác
Reported 2016-07-21 06:12:34 PDT
https://trac.webkit.org/changeset/203440 removed the possibility to skip redundant tests on non FTL platforms which made testing terrible slow ( just to be able to paint some bots green ... ) r203440 stated that default should really mean default, not default with disabled FTL JIT. Let's do the following renaming to have clear names: - runMozillaTestDefault -> runMozillaTestNoFTL - runMozillaTestDefaultFTL -> runMozillaTestDefault - runDefault -> runNoFTL - runDefaultFTL -> runDefault
Attachments
Patch (37.88 KB, patch)
2016-07-21 06:20 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (40.05 KB, patch)
2016-07-21 08:07 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (40.93 KB, patch)
2016-07-21 10:28 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2016-07-21 06:20:15 PDT
Created attachment 284210 [details] Patch no behavior change, only renaming
Csaba Osztrogonác
Comment 2 2016-07-21 07:32:23 PDT
(In reply to comment #0) > Let's do the following renaming to have clear names: > - runMozillaTestDefault -> runMozillaTestNoFTL > - runMozillaTestDefaultFTL -> runMozillaTestDefault > - runDefault -> runNoFTL > - runDefaultFTL -> runDefault and - runLayoutTestDefault -> runLayoutTestNoFTL - runLayoutTestDefaultFTL -> runLayoutTestDefault
Csaba Osztrogonác
Comment 3 2016-07-21 08:07:19 PDT
Created attachment 284216 [details] Patch
Csaba Osztrogonác
Comment 4 2016-07-21 10:26:02 PDT
and - runNoisyTestDefault to runNoisyTestNoFTL - runNoisyTestDefaultFTL to runNoisyTestDefault
Csaba Osztrogonác
Comment 5 2016-07-21 10:28:47 PDT
Created attachment 284225 [details] Patch
Mark Lam
Comment 6 2016-07-21 10:58:42 PDT
Comment on attachment 284225 [details] Patch r=me if EWS bots are happy.
Csaba Osztrogonác
Comment 7 2016-07-21 11:09:44 PDT
Comment on attachment 284225 [details] Patch Clearing flags on attachment: 284225 Committed r203512: <http://trac.webkit.org/changeset/203512>
Csaba Osztrogonác
Comment 8 2016-07-21 11:09:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.