Summary: | WebBackForwardList's currentIndex could get out of bounds when filtering items. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yongjun Zhang <yongjun_zhang> | ||||||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | andersca, beidson, commit-queue, mitz, sam, thorton | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | Other | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Yongjun Zhang
2016-07-20 14:22:50 PDT
Created attachment 284156 [details]
Patch.
Attachment 284156 [details] did not pass style-queue:
ERROR: Tools/TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm:31: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm:80: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 2 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 284158 [details]
Fix style issues.
Comment on attachment 284158 [details]
Fix style issues.
Oops, sorry, reverting the flag change.
Created attachment 284169 [details]
Fix style issues.
Comment on attachment 284169 [details] Fix style issues. Attachment 284169 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1718233 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-03.html Created attachment 284175 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.5
The iOS simulator test failure doesn't seem to be related with this patch. Comment on attachment 284169 [details] Fix style issues. Clearing flags on attachment: 284169 Committed r203508: <http://trac.webkit.org/changeset/203508> All reviewed patches have been landed. Closing bug. |