Bug 159986

Summary: WebBackForwardList's currentIndex could get out of bounds when filtering items.
Product: WebKit Reporter: Yongjun Zhang <yongjun_zhang>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, beidson, commit-queue, mitz, sam, thorton
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch.
none
Fix style issues.
none
Fix style issues.
none
Archive of layout-test-results from ews126 for ios-simulator-wk2 none

Yongjun Zhang
Reported 2016-07-20 14:22:50 PDT
In WebBackForwardList::backForwardListState, if we are filtering multiple items and generating a new BackForwardListState, the new list's currentIndex could get out of bounds. If we restore the new state to a web view, accessing to its currentItem later could lead to a crash.
Attachments
Patch. (10.12 KB, patch)
2016-07-20 15:31 PDT, Yongjun Zhang 		no flags
DetailsFormatted DiffDiff
Fix style issues. (10.12 KB, patch)
2016-07-20 15:43 PDT, Yongjun Zhang 		no flags
DetailsFormatted DiffDiff
Fix style issues. (10.13 KB, patch)
2016-07-20 16:37 PDT, Yongjun Zhang 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (3.48 MB, application/zip)
2016-07-20 17:36 PDT, Build Bot 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yongjun Zhang
Comment 1 2016-07-20 14:23:53 PDT
rdar://problem/27392691
Yongjun Zhang
Comment 2 2016-07-20 15:31:51 PDT
Created attachment 284156 [details] Patch.
WebKit Commit Bot
Comment 3 2016-07-20 15:34:25 PDT
Attachment 284156 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm:80: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yongjun Zhang
Comment 4 2016-07-20 15:43:08 PDT
Created attachment 284158 [details] Fix style issues.
Ryosuke Niwa
Comment 5 2016-07-20 16:16:04 PDT
Comment on attachment 284158 [details] Fix style issues. Oops, sorry, reverting the flag change.
Yongjun Zhang
Comment 6 2016-07-20 16:37:33 PDT
Created attachment 284169 [details] Fix style issues.
Build Bot
Comment 7 2016-07-20 17:36:29 PDT
Comment on attachment 284169 [details] Fix style issues. Attachment 284169 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1718233 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-03.html
Build Bot
Comment 8 2016-07-20 17:36:32 PDT
Created attachment 284175 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.5
Yongjun Zhang
Comment 9 2016-07-21 09:49:41 PDT
The iOS simulator test failure doesn't seem to be related with this patch.
WebKit Commit Bot
Comment 10 2016-07-21 10:02:08 PDT
Comment on attachment 284169 [details] Fix style issues. Clearing flags on attachment: 284169 Committed r203508: <http://trac.webkit.org/changeset/203508>
WebKit Commit Bot
Comment 11 2016-07-21 10:02:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.