Bug 159961

Summary: Remove unnecessary if check from ParkingLot.cpp
Product: WebKit Reporter: Rajeev Misra <rajeevmisraforapple>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, commit-queue, fpizlo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Rajeev Misra
Reported 2016-07-19 16:51:11 PDT
Remove unnecessary if check from ParkingLot.cpp
Attachments
Patch (1.08 KB, patch)
2016-07-19 19:36 PDT, Rajeev Misra 		no flags
DetailsFormatted DiffDiff
Patch (1.91 KB, patch)
2016-07-20 00:29 PDT, Rajeev Misra 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rajeev Misra
Comment 1 2016-07-19 19:36:35 PDT
Created attachment 284078 [details] Patch
Rajeev Misra
Comment 2 2016-07-19 19:38:55 PDT
Just learning the checkin process. A simple patch to reorder the case to avoid "if" statement which seems unnecessary as switch/case has already given us info if result is to stop or continue.
Alex Christensen
Comment 3 2016-07-19 23:23:07 PDT
Great! This patch needs a ChangeLog entry to go with it. Use Tools/Scripts/prepare-ChangeLog to generate a template, and then fill it in with a description like you see on trac.webkit.org
Rajeev Misra
Comment 4 2016-07-20 00:29:24 PDT
Created attachment 284089 [details] Patch
WebKit Commit Bot
Comment 5 2016-07-20 13:01:01 PDT
Comment on attachment 284089 [details] Patch Clearing flags on attachment: 284089 Committed r203466: <http://trac.webkit.org/changeset/203466>
WebKit Commit Bot
Comment 6 2016-07-20 13:01:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.