Bug 15995

Summary: Bring match() up-to-date with WebKit style guidelines in preparation for real hacking
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: JavaScriptCoreAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
the patch (ignoring whitespace)
none
patch (really ignoring whitespace) sam: review+

Eric Seidel (no email)
Reported 2007-11-15 01:15:13 PST
Bring match() up-to-date with WebKit style guidelines in preparation for real hacking It's kinda sucky to do these white-space/style-update patches, but at least now the PCRE match() code is more readable to those accustomed to WebKit code.
Attachments
the patch (ignoring whitespace) (57.52 KB, patch)
2007-11-15 01:15 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
patch (really ignoring whitespace) (51.92 KB, patch)
2007-11-15 01:17 PST, Eric Seidel (no email) 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2007-11-15 01:15:36 PST
Created attachment 17287 [details] the patch (ignoring whitespace)
Eric Seidel (no email)
Comment 2 2007-11-15 01:17:15 PST
Created attachment 17288 [details] patch (really ignoring whitespace)
Eric Seidel (no email)
Comment 3 2007-11-15 01:34:26 PST
Next on the chopping block is some of the needless gotos. At least RETURN_ERROR can go right off the bat.
Sam Weinig
Comment 4 2007-11-15 10:17:39 PST
Comment on attachment 17288 [details] patch (really ignoring whitespace) Needs a changelog. r=me
Eric Seidel (no email)
Comment 5 2007-11-15 16:15:02 PST
Landed.
Note You need to log in before you can comment on or make changes to this bug.