Summary: | PCRE needs a bath | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||
Component: | JavaScriptCore | Assignee: | Eric Seidel (no email) <eric> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2007-11-14 16:12:48 PST
Created attachment 17284 [details]
the patch
Oh, and the very very first thing I did was to ask Xcode to re-indent the entire jsRegExpCompile function so I had some clue where blocks started and ended. :) Created attachment 17285 [details]
Add a couple more minor cleanups to PCRE, -b diff
This now includes some additional cleanup I'd been working on for my next patch. However using -b to ignore whitespace makes for a smaller patch even with those extra changes. I can get you the original diff ignoring whitespace if that would be easier.
My additional changes were to add a constructor to compile_data and to break out the debug printf code into its own separate function. I also added returnError to replace the PCRE_ERROR_RETURN goto.
Yay for more-readable code!
|