Bug 159907

Summary: Improve prepare-ChangeLog for @media blocks
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, dbates, ddkilzer, jond, lforschler, timothy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2016-07-18 16:31:29 PDT
Improve prepare-ChangeLog for @media blocks. prepare-ChangeLog's CSS parsing was never expecting any nested braces, so it was very confused by `@media (...) { ... }` blocks containing selectors. Make it reason about an @media block much like a namespace. It will output the media query in the ChangeLog like a selector.
Attachments
[PATCH] Proposed Fix (8.92 KB, patch)
2016-07-18 16:33 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-07-18 16:33:11 PDT
Created attachment 283955 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2016-07-20 08:41:02 PDT
Comment on attachment 283955 [details] [PATCH] Proposed Fix Clearing flags on attachment: 283955 Committed r203453: <http://trac.webkit.org/changeset/203453>
WebKit Commit Bot
Comment 3 2016-07-20 08:41:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.