Bug 159884 – LayoutTest http/tests/loading/basic-auth-resend-wrong-credentials.html is flaky on WK2

• Component: New Bugs
• Status: RESOLVED FIXED

[Ryan Haddad]

LayoutTest http/tests/loading/basic-auth-resend-wrong-credentials.html is flaky on WK2

This test is a flaky failure on El Cap Debug WK2, Yosemite Debug/Release WK2, and iOS Simulator Debug WK2

https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Debug%20WK2%20(Tests)/builds/3513

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Floading%2Fbasic-auth-resend-wrong-credentials.html

--- /Volumes/Data/slave/ios-simulator-9-debug-tests-wk2/build/layout-test-results/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt
+++ /Volumes/Data/slave/ios-simulator-9-debug-tests-wk2/build/layout-test-results/http/tests/loading/basic-auth-resend-wrong-credentials-actual.txt
@@ -1,8 +1,8 @@
 main frame - didStartProvisionalLoadForFrame
 main frame - didCommitLoadForFrame
 frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
+127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with wrongusername:wrongpassword
 main frame - didFinishDocumentLoadForFrame
-127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with wrongusername:wrongpassword
 frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
 frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
 frame "<!--framePath //<!--frame1-->-->" - didStartProvisionalLoadForFrame

[Ryan Haddad]

Marked as flaky in <http://trac.webkit.org/projects/webkit/changeset/203357>

[Ryan Haddad]

The test is still flaky even after https://bugs.webkit.org/show_bug.cgi?id=178370 and https://bugs.webkit.org/show_bug.cgi?id=178467

[Ryan Haddad]

Diff from recent failure:

--- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/http/tests/loading/basic-auth-resend-wrong-credentials-actual.txt
@@ -9,8 +9,8 @@
 frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
 frame "<!--framePath //<!--frame1-->-->" - didStartProvisionalLoadForFrame
 frame "<!--framePath //<!--frame0-->-->" - didHandleOnloadEventsForFrame
+127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with correctusername:correctpassword
 frame "<!--framePath //<!--frame0-->-->" - didFinishLoadForFrame
-127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with correctusername:correctpassword
 frame "<!--framePath //<!--frame1-->-->" - didCommitLoadForFrame
 frame "<!--framePath //<!--frame1-->-->" - didFinishDocumentLoadForFrame
 This test makes sure that once WebCore preemptively sends out Basic credentials it thinks apply to a new resource, and that resource response with a 401 challenge, that it doesn't try to send the same wrong credentials a second time.

[Alex Christensen]

Created attachment 325959 [details]
Patch

[Darin Adler]

Comment on attachment 325959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325959&action=review

> LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials.html:14
>  function firstFrameLoaded() {

Could also have just done iframe.onload="setTimeout(firstFrameLoaded, 0)" ?

[Alex Christensen]

That could accomplish the same thing.
http://trac.webkit.org/r224432

[Radar WebKit Bug Importer]

<rdar://problem/35568933>