Bug 159870

Summary:

[Streams API] ReadableStream should throw a RangeError in case of NaN highWaterMark

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, buildbot, calvaris, commit-queue, rniwa, romain.wkt

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

138561

Attachments:

Description	Flags
Patch	buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews104 for mac-yosemite-wk2	none
Patch	none
Patch for landing	none

youenn fablet

Reported 2016-07-18 00:42:04 PDT

The spec changed, ReadableStream should throw a RangeError in case of NaN highWaterMark

Attachments
Patch (4.61 KB, patch) 2016-07-18 00:46 PDT, youenn fablet	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-yosemite (793.12 KB, application/zip) 2016-07-18 01:35 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (774.16 KB, application/zip) 2016-07-18 01:38 PDT, Build Bot	no flags	Details
Patch (5.97 KB, patch) 2016-07-18 02:35 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (6.00 KB, patch) 2016-07-18 06:11 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2016-07-18 00:46:54 PDT

Created attachment 283888 [details] Patch

Build Bot

Comment 2 2016-07-18 01:35:24 PDT

Comment on attachment 283888 [details] Patch Attachment 283888 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1700408 New failing tests: streams/reference-implementation/bad-strategies.html

Build Bot

Comment 3 2016-07-18 01:35:26 PDT

Created attachment 283890 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 4 2016-07-18 01:38:04 PDT

Comment on attachment 283888 [details] Patch Attachment 283888 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1700409 New failing tests: streams/reference-implementation/bad-strategies.html

Build Bot

Comment 5 2016-07-18 01:38:06 PDT

Created attachment 283891 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

youenn fablet

Comment 6 2016-07-18 02:35:48 PDT

Created attachment 283895 [details] Patch

Xabier Rodríguez Calvar

Comment 7 2016-07-18 04:12:29 PDT

Comment on attachment 283895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283895&action=review > Source/WebCore/Modules/streams/StreamInternals.js:88 > + if (@isNaN(normalizedStrategy.highWaterMark) || normalizedStrategy.highWaterMark < 0) Extra line before ||

youenn fablet

Comment 8 2016-07-18 06:11:39 PDT

Created attachment 283903 [details] Patch for landing

WebKit Commit Bot

Comment 9 2016-07-18 06:42:01 PDT

Comment on attachment 283903 [details] Patch for landing Clearing flags on attachment: 283903 Committed r203347: <http://trac.webkit.org/changeset/203347>

WebKit Commit Bot

Comment 10 2016-07-18 06:42:08 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.