Bug 159849

Summary: Web Inspector: UI polish for Open Quickly and Goto Line dialogs
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 172110    
Attachments:
Description Flags
[Image] New UI
none
[Image] New UI (with results)
none
[Patch] Proposed Fix none

Matt Baker
Reported 2016-07-15 16:40:17 PDT
Show the search icon in both dialogs, and add a separator between Open Quickly's input field and results list. Both styles are present in Xcode 8. This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=159823.
Attachments
[Image] New UI (101.29 KB, image/png)
2016-08-03 18:52 PDT, Matt Baker 		no flags
Details
[Image] New UI (with results) (210.04 KB, image/png)
2016-08-03 18:53 PDT, Matt Baker 		no flags
Details
[Patch] Proposed Fix (7.79 KB, patch)
2016-08-03 20:31 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-07-15 16:40:54 PDT
<rdar://problem/27383068>
Matt Baker
Comment 2 2016-08-03 18:52:53 PDT
Created attachment 285295 [details] [Image] New UI
Matt Baker
Comment 3 2016-08-03 18:53:25 PDT
Created attachment 285296 [details] [Image] New UI (with results)
Matt Baker
Comment 4 2016-08-03 20:31:22 PDT
Created attachment 285299 [details] [Patch] Proposed Fix
Blaze Burg
Comment 5 2016-08-04 10:28:07 PDT
Comment on attachment 285299 [details] [Patch] Proposed Fix r=me
WebKit Commit Bot
Comment 6 2016-08-04 10:48:40 PDT
Comment on attachment 285299 [details] [Patch] Proposed Fix Clearing flags on attachment: 285299 Committed r204124: <http://trac.webkit.org/changeset/204124>
WebKit Commit Bot
Comment 7 2016-08-04 10:48:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.