Bug 15983

Summary:

run-sunspider needs a --shark-cache option for L2 Cache miss profiling

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, ggaren

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
the fix	sam: review+

Description Eric Seidel (no email) 2007-11-14 01:51:55 PST

run-sunspider needs a --shark-cache option for L2 Cache miss profiling

Comment 1 Eric Seidel (no email) 2007-11-14 01:52:15 PST

Created attachment 17265 [details]
the fix

Comment 2 Sam Weinig 2007-11-14 11:38:42 PST

Comment on attachment 17265 [details]
the fix

Your indentation is off, we like to use 4 spaces, not 2.  Other than that. r=me.  Please also remember to add a changelog.

Comment 3 Eric Seidel (no email) 2007-11-14 12:38:21 PST

Landed as r27790.  Hopefully the other --shark users will find this useful.