Bug 15977

Summary: match firefox's preference for resizing images
Product: WebKit Reporter: rahul abrol <solushex>
Component: ImagesAssignee: Nobody <webkit-unassigned>
Status: UNCONFIRMED    
Severity: Normal CC: andersca, mrowe, webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch v1
none
patch v1 w/better changelog none

rahul abrol
Reported 2007-11-13 22:09:34 PST
WebKitShrinksStandaloneImagesToFitKey (from bug 5400) is an all or none preference; setting it to 0 removes resizing altogether. i suggest matching firefox's behavior, where the pref. controls whether the image is resized by default, but the option to resize via left-click is always present.
Attachments
patch v1 (1.54 KB, patch)
2007-11-13 22:13 PST, rahul abrol 		no flags
DetailsFormatted DiffDiff
patch v1 w/better changelog (1.60 KB, patch)
2007-11-14 00:50 PST, rahul abrol 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
rahul abrol
Comment 1 2007-11-13 22:13:10 PST
Created attachment 17257 [details] patch v1 simple patch.
Mark Rowe (bdash)
Comment 2 2007-11-13 23:23:13 PST
Can you please fill in the ChangeLog rather than leaving it empty. Name, email address and a description of the change is required.
rahul abrol
Comment 3 2007-11-14 00:50:32 PST
Created attachment 17264 [details] patch v1 w/better changelog
Mark Rowe (bdash)
Comment 4 2007-11-19 05:44:14 PST
Landed in r27903.
rahul abrol
Comment 5 2007-11-19 16:08:21 PST
i can't verify this. safari 3.0.4 calls setShrinksStandaloneImagesToFit: which sets WebKitShrinksStandaloneImagesToFitKey to 1 on launch regardless of its previous value. i don't understand this. is setShrinksStandaloneImagesToFit: getting called with no parameter?
rahul abrol
Comment 6 2008-03-19 10:08:29 PDT
r28200 undid this patch. http://trac.webkit.org/projects/webkit/changeset/28200 if this was intentional, then "fixed" is the wrong resolution.
Mark Rowe (bdash)
Comment 7 2008-03-22 15:22:29 PDT
Comment on attachment 17264 [details] patch v1 w/better changelog Clearing review flag since the patch was landed.
Mark Rowe (bdash)
Comment 8 2008-03-22 15:23:38 PDT
Anders, can you comment on why <http://trac.webkit.org/projects/webkit/changeset/28200> reverted this behaviour?
Anders Carlsson
Comment 9 2008-03-24 09:11:46 PDT
Because of backwards compatibility. There might be apps that rely on images not being autoresized, which is why we added the preference in the first place.
Robert Blaut
Comment 10 2008-07-28 11:10:19 PDT
(In reply to comment #9) > Because of backwards compatibility. There might be apps that rely on images not > being autoresized, which is why we added the preference in the first place. > So, is it impossible to fix the bug? If yes, it should be marked as WONTFIX.
Note You need to log in before you can comment on or make changes to this bug.