Bug 159738

Summary: [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, lforschler, mitz, ryanhaddad
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch mitz: review+

Description Daniel Bates 2016-07-13 14:43:03 PDT
We should copy WebKitTestRunnerInjectedBundle.bundle to the PlugIn subdirectory of the WebKitTestRunnerApp.app bundle so as to make the bundle hierarchy of WebKitTestRunnerApp.app more closely conform to the bundle hierarchy of an iOS app. We should also code sign WebKitTestRunnerInjectedBundle.bundle because it contains executable code and is loaded by WebKitTestRunnerApp.app, which may be code signed.
Comment 1 Daniel Bates 2016-07-13 14:49:33 PDT
Created attachment 283568 [details]
Patch
Comment 2 Daniel Bates 2016-07-13 14:50:19 PDT
<rdar://problem/27304649>
Comment 3 mitz 2016-07-13 14:51:12 PDT
Comment on attachment 283568 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283568&action=review

> Tools/ChangeLog:10
> +        code signed should WebKitTestRunnerApp be code signed. We should also copy this bundle

“should WebKitTestRunnerApp be code signed”?

> Tools/WebKitTestRunner/ios/TestControllerIOS.mm:68
> +    NSString *nsBundlePath = [[[NSBundle mainBundle] builtInPlugInsPath] stringByAppendingPathComponent:@"WebKitTestRunnerInjectedBundle.bundle"];

You can use property syntax here.
Comment 4 Daniel Bates 2016-07-13 19:38:12 PDT
(In reply to comment #3)
> > Tools/ChangeLog:10
> > +        code signed should WebKitTestRunnerApp be code signed. We should also copy this bundle
> 
> “should WebKitTestRunnerApp be code signed”?
> 

I changed this sentence to read:

The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be code signed if applicable.

> > Tools/WebKitTestRunner/ios/TestControllerIOS.mm:68
> > +    NSString *nsBundlePath = [[[NSBundle mainBundle] builtInPlugInsPath] stringByAppendingPathComponent:@"WebKitTestRunnerInjectedBundle.bundle"];
> 
> You can use property syntax here.

Will fix before landing.
Comment 5 Daniel Bates 2016-07-13 19:39:08 PDT
Committed r203209: <http://trac.webkit.org/changeset/203209>