Bug 159738 – [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Daniel Bates]

We should copy WebKitTestRunnerInjectedBundle.bundle to the PlugIn subdirectory of the WebKitTestRunnerApp.app bundle so as to make the bundle hierarchy of WebKitTestRunnerApp.app more closely conform to the bundle hierarchy of an iOS app. We should also code sign WebKitTestRunnerInjectedBundle.bundle because it contains executable code and is loaded by WebKitTestRunnerApp.app, which may be code signed.

[Daniel Bates]

Created attachment 283568 [details]
Patch

[Daniel Bates]

<rdar://problem/27304649>

Comment on attachment 283568 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283568&action=review

> Tools/ChangeLog:10
> +        code signed should WebKitTestRunnerApp be code signed. We should also copy this bundle

“should WebKitTestRunnerApp be code signed”?

> Tools/WebKitTestRunner/ios/TestControllerIOS.mm:68
> +    NSString *nsBundlePath = [[[NSBundle mainBundle] builtInPlugInsPath] stringByAppendingPathComponent:@"WebKitTestRunnerInjectedBundle.bundle"];

You can use property syntax here.

[Daniel Bates]

(In reply to comment #3)
> > Tools/ChangeLog:10
> > +        code signed should WebKitTestRunnerApp be code signed. We should also copy this bundle
> 
> “should WebKitTestRunnerApp be code signed”?
> 

I changed this sentence to read:

The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be code signed if applicable.

> > Tools/WebKitTestRunner/ios/TestControllerIOS.mm:68
> > +    NSString *nsBundlePath = [[[NSBundle mainBundle] builtInPlugInsPath] stringByAppendingPathComponent:@"WebKitTestRunnerInjectedBundle.bundle"];
> 
> You can use property syntax here.

Will fix before landing.

[Daniel Bates]

Committed r203209: <http://trac.webkit.org/changeset/203209>