Bug 159737

Summary: Full screen ePub embedded video is playing on 1/4 screen, cut off
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, jonlee, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: InRadar
Attachments:
Description Flags
Patch thorton: review+

Description Jer Noble 2016-07-13 14:27:51 PDT
Full screen ePub embedded video is playing on 1/4 screen, cut off
Comment 1 Jer Noble 2016-07-13 14:28:10 PDT
<rdar://problem/26259404>
Comment 2 Radar WebKit Bug Importer 2016-07-13 14:28:33 PDT
<rdar://problem/27332427>
Comment 3 Jer Noble 2016-07-13 14:34:47 PDT
Created attachment 283566 [details]
Patch
Comment 4 Tim Horton 2016-07-13 14:38:09 PDT
Comment on attachment 283566 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283566&action=review

> Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:1010
> +        setFixedLayoutSize(CGSizeZero);

Somewhat surprising that WKViewFixedSizeLayoutStrategy doesn't do this in willChangeLayoutStrategy. Maybe it should be there? I don't know.
Comment 5 Tim Horton 2016-07-13 14:38:45 PDT
Also somewhat concerned that something is using the fixed layout size when fixed layout is off... seems bad.
Comment 6 Jon Lee 2016-07-14 14:01:32 PDT
<rdar://problem/26259404>
Comment 7 Dean Jackson 2016-07-15 13:43:34 PDT
Committed r203295: <http://trac.webkit.org/changeset/203295>