Bug 159715

Summary: Import more tests from the MathML in HTML5 test suite
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: MathMLAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, commit-queue, dbarton, rego, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 139403, 157989, 158866    
Bug Blocks:    
Attachments:
Description Flags
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-yosemite
none
Archive of layout-test-results from ews104 for mac-yosemite-wk2
none
Archive of layout-test-results from ews116 for mac-yosemite
none
Archive of layout-test-results from ews122 for ios-simulator-wk2
none
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-yosemite-wk2
none
Archive of layout-test-results from ews101 for mac-yosemite
none
Patch none

Description Frédéric Wang (:fredw) 2016-07-13 08:31:54 PDT
Many of the tests from the MathML in HTML5 suite pass in WebKit, so we can import them. Removing old and unexplained CSS rules from the MathML user agent stylesheet will help here (bug 157989 and bug 139403).
Comment 1 Frédéric Wang (:fredw) 2016-07-14 05:39:01 PDT
Created attachment 283633 [details]
Patch
Comment 2 Build Bot 2016-07-14 06:26:35 PDT
Comment on attachment 283633 [details]
Patch

Attachment 283633 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1680018

New failing tests:
imported/mathml-in-html5/mathml/relations/text-and-math/use-typo-metrics-1.html
imported/mathml-in-html5/mathml/relations/css-styling/color-1.html
Comment 3 Build Bot 2016-07-14 06:26:38 PDT
Created attachment 283635 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-07-14 06:28:43 PDT
Comment on attachment 283633 [details]
Patch

Attachment 283633 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1680023

New failing tests:
imported/mathml-in-html5/mathml/relations/text-and-math/use-typo-metrics-1.html
imported/mathml-in-html5/mathml/relations/css-styling/color-1.html
Comment 5 Build Bot 2016-07-14 06:28:46 PDT
Created attachment 283636 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-07-14 06:39:33 PDT
Comment on attachment 283633 [details]
Patch

Attachment 283633 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1680032

New failing tests:
imported/mathml-in-html5/mathml/relations/text-and-math/use-typo-metrics-1.html
imported/mathml-in-html5/mathml/relations/css-styling/color-1.html
Comment 7 Build Bot 2016-07-14 06:39:36 PDT
Created attachment 283638 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-07-14 06:50:12 PDT
Comment on attachment 283633 [details]
Patch

Attachment 283633 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1680051

New failing tests:
imported/mathml-in-html5/mathml/relations/text-and-math/use-typo-metrics-1.html
Comment 9 Build Bot 2016-07-14 06:50:15 PDT
Created attachment 283639 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5
Comment 10 Frédéric Wang (:fredw) 2016-07-14 11:44:05 PDT
The failure of the typo test on mac / ios is expected as the USE_TYPO_METRICS is ignored for non-math fonts on these platforms (bug 150394 comment 12). The other failure just seems a 1-pixel diff due to antialiasing. I'll try uploading a new patch tomorrow.
Comment 11 Frédéric Wang (:fredw) 2016-07-15 00:29:36 PDT
Created attachment 283744 [details]
Patch
Comment 12 Build Bot 2016-07-15 01:01:53 PDT
Comment on attachment 283744 [details]
Patch

Attachment 283744 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1684395

New failing tests:
imported/mathml-in-html5/mathml/relations/text-and-math/use-typo-metrics-1.html
imported/mathml-in-html5/mathml/relations/css-styling/color-1.html
Comment 13 Build Bot 2016-07-15 01:01:57 PDT
Created attachment 283745 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 14 Build Bot 2016-07-15 01:03:23 PDT
Comment on attachment 283744 [details]
Patch

Attachment 283744 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1684405

New failing tests:
imported/mathml-in-html5/mathml/relations/text-and-math/use-typo-metrics-1.html
imported/mathml-in-html5/mathml/relations/css-styling/color-1.html
Comment 15 Build Bot 2016-07-15 01:03:26 PDT
Created attachment 283746 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 16 Frédéric Wang (:fredw) 2016-07-15 01:05:17 PDT
Created attachment 283747 [details]
Patch

Oops, I uploaded the wrong patch. Here is the correct one.
Comment 17 Brent Fulgham 2016-07-15 09:27:20 PDT
Comment on attachment 283747 [details]
Patch

Yay! More tests! :-) r=me.
Comment 18 WebKit Commit Bot 2016-07-15 09:49:07 PDT
Comment on attachment 283747 [details]
Patch

Clearing flags on attachment: 283747

Committed r203278: <http://trac.webkit.org/changeset/203278>
Comment 19 WebKit Commit Bot 2016-07-15 09:49:12 PDT
All reviewed patches have been landed.  Closing bug.