Bug 159686 – REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker

• Component: Forms
• Status: RESOLVED FIXED

[Ryosuke Niwa]

After https://trac.webkit.org/changeset/202953, user can't open file picker on a file input field.

[Ryosuke Niwa]

<rdar://problem/27263589>

[Ryosuke Niwa]

Created attachment 283444 [details]
Fixes the bug

[Chris Dumez]

Comment on attachment 283444 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=283444&action=review

> Source/WebCore/dom/Event.cpp:100
> +        || m_type == eventNames().DOMActivateEvent

How about DOMFocusIn / DOMFocusOut events?
https://github.com/w3c/uievents/pull/93/files seems to indicate they should be composed as well.

> LayoutTests/fast/forms/file/open-file-panel.html:5
> +To manually test, click on the button below. WebKit should open a file picker.</p>

We should probably add a line saying this test passes if "OPEN FILE PANEL" is printed.

[Chris Dumez]

Looks like it is failing some tests on the bots as well:

Regressions: Unexpected text-only failures (3)
  accessibility/axpress-on-aria-button.html [ Failure ]
  accessibility/file-upload-button-with-axpress.html [ Failure ]
  fast/events/domactivate-sets-underlying-click-event-as-handled.html [ Failure ]

[Ryosuke Niwa]

Comment on attachment 283444 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=283444&action=review

>> Source/WebCore/dom/Event.cpp:100
>> +        || m_type == eventNames().DOMActivateEvent
> 
> How about DOMFocusIn / DOMFocusOut events?
> https://github.com/w3c/uievents/pull/93/files seems to indicate they should be composed as well.

They're covered by isFocusEvent check below.

>> LayoutTests/fast/forms/file/open-file-panel.html:5
>> +To manually test, click on the button below. WebKit should open a file picker.</p>
> 
> We should probably add a line saying this test passes if "OPEN FILE PANEL" is printed.

Sure, not when it's manually tested though.

[Build Bot]

Comment on attachment 283444 [details]
Fixes the bug

Attachment 283444 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1670506

New failing tests:
fast/events/domactivate-sets-underlying-click-event-as-handled.html
accessibility/axpress-on-aria-button.html
accessibility/file-upload-button-with-axpress.html

[Build Bot]

Created attachment 283452 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 283444 [details]
Fixes the bug

Attachment 283444 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1670505

New failing tests:
fast/forms/file/open-file-panel.html

[Build Bot]

Created attachment 283454 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5

[Ryosuke Niwa]

Created attachment 283462 [details]
Rebaselined tests

[Build Bot]

Comment on attachment 283462 [details]
Rebaselined tests

Attachment 283462 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1670848

New failing tests:
fast/forms/file/open-file-panel.html

[Build Bot]

Created attachment 283468 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5

[Ryosuke Niwa]

Created attachment 283474 [details]
Skip the test on iOS

[Carlos Garcia Campos]

*** Bug 159675 has been marked as a duplicate of this bug. ***

[Chris Dumez]

Comment on attachment 283474 [details]
Skip the test on iOS

View in context: https://bugs.webkit.org/attachment.cgi?id=283474&action=review

r=me with comment.

> LayoutTests/fast/forms/file/open-file-panel-expected.txt:2
> +This test checks that clicking on an file input field opens up a file picker.

Again, there is no information about determining if this test is passing (when running as a layout test). You only provide instructions about running this manually which is not the common case. What's going to prevent someone from rebasing this file in the future if the "OPEN FILE PANEL" is no longer printed? Without the "OPEN FILE PANEL", it is currently not obvious that this test is failing.

[Ryosuke Niwa]

Comment on attachment 283474 [details]
Skip the test on iOS

View in context: https://bugs.webkit.org/attachment.cgi?id=283474&action=review

>> LayoutTests/fast/forms/file/open-file-panel-expected.txt:2
>> +This test checks that clicking on an file input field opens up a file picker.
> 
> Again, there is no information about determining if this test is passing (when running as a layout test). You only provide instructions about running this manually which is not the common case. What's going to prevent someone from rebasing this file in the future if the "OPEN FILE PANEL" is no longer printed? Without the "OPEN FILE PANEL", it is currently not obvious that this test is failing.

Oh oops, I forgot to add that. Will do before landing.

[Ryosuke Niwa]

Committed r203187: <http://trac.webkit.org/changeset/203187>