Bug 159675
| Summary: | REGRESSION(r202953): [GTK] API test /WebKit2Gtk/TestUIClient timing out | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | bugs-noreply, cdumez, cgarcia, rniwa |
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Michael Catanzaro
API test /WebKit2Gtk/TestUIClient is timing out since r202953 ("Replace scoped flag in Event by composed flag"). I have not investigated why.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Garcia Campos
I don't think this is GTK specific. The problem is that after r202953, shouldEventCrossShadowBoundary() is returning true when handling DOMActivate events on input fields. That means that for example, in the case of file upload input type, the element handling the DOMActivate event is not the FileInputType but its button. Since ButtonInputType doesn't handle DOMActivate events, the runOpenPanel method is never called on the chrome. Same happens with the color picker. Chris, Ryosuke could you guys confirm that file upload doesn't show the file chooser in mac either? I'm surprised this didn't break layout tests. Our unit tests are failing because they keep waiting for the runOpenPanel to happen.
Chris Dumez
Ryosuke is working on this via https://bugs.webkit.org/show_bug.cgi?id=159686 already. We should probably dupe this.
Carlos Garcia Campos
Indeed, thanks!
*** This bug has been marked as a duplicate of bug 159686 ***