Bug 159653

Summary: defineProperty on a index of a TypedArray should throw if configurable
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+, saam: commit-queue-

Keith Miller
Reported 2016-07-11 16:21:57 PDT
defineProperty on a index of a TypedArray should throw if configurable
Attachments
Patch (7.30 KB, patch)
2016-07-11 16:23 PDT, Keith Miller 		saam: review+
saam: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-07-11 16:23:51 PDT
Created attachment 283361 [details] Patch
Saam Barati
Comment 2 2016-07-11 16:27:47 PDT
Comment on attachment 283361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283361&action=review r=me with a suggestion > Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h:351 > + if (!(descriptor.attributes() & DontDelete)) I think this is cleaner if you just call: "descriptor.configurable()" > Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h:354 > + if (descriptor.attributes() & (DontEnum | ReadOnly)) ditto here but with descriptor.enumerable() and descriptor.writable()
Keith Miller
Comment 3 2016-07-11 16:38:19 PDT
Comment on attachment 283361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283361&action=review >> Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h:351 >> + if (!(descriptor.attributes() & DontDelete)) > > I think this is cleaner if you just call: "descriptor.configurable()" Fixed. >> Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h:354 >> + if (descriptor.attributes() & (DontEnum | ReadOnly)) > > ditto here but with descriptor.enumerable() and descriptor.writable() Fixed.
Keith Miller
Comment 4 2016-07-11 16:40:14 PDT
Committed r203096: <http://trac.webkit.org/changeset/203096>
Note You need to log in before you can comment on or make changes to this bug.