Bug 159636

Summary: Import W3C WebCryptoAPI tests
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebCore Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, bfulgham, cdumez, jiewen_tan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 159638    
Attachments:
Description Flags
Patch
none
Patch
none
Patch jiewen_tan: commit-queue+

Jiewen Tan
Reported 2016-07-11 12:33:07 PDT
Import W3C WebCryptoAPI tests
Attachments
Patch (245.38 KB, patch)
2016-07-11 14:20 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (245.38 KB, patch)
2016-07-13 11:15 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (245.34 KB, patch)
2016-07-13 15:01 PDT, Jiewen Tan 		jiewen_tan: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2016-07-11 14:20:23 PDT
Created attachment 283344 [details] Patch
Alex Christensen
Comment 2 2016-07-12 22:41:20 PDT
Comment on attachment 283344 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283344&action=review I think importing tests is a good idea. > LayoutTests/ChangeLog:9 > + Skip test cases for unimplemented features. Do we want to skip them, or run them and see the expected failures? > LayoutTests/TestExpectations:988 > +# WebCryptoAPI tests, skip for unimplemented features. webkit.org/b/156631 I don't think this link is correct.
Jiewen Tan
Comment 3 2016-07-13 11:11:29 PDT
Comment on attachment 283344 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283344&action=review Alex, thank you for reviewing my patch. >> LayoutTests/ChangeLog:9 >> + Skip test cases for unimplemented features. > > Do we want to skip them, or run them and see the expected failures? Those test cases time out actually. That's why I skip them. >> LayoutTests/TestExpectations:988 >> +# WebCryptoAPI tests, skip for unimplemented features. webkit.org/b/156631 > > I don't think this link is correct. Oops!
Alex Christensen
Comment 4 2016-07-13 11:13:10 PDT
Comment on attachment 283344 [details] Patch ok. fix the link
Jiewen Tan
Comment 5 2016-07-13 11:15:16 PDT
Created attachment 283548 [details] Patch
Jiewen Tan
Comment 6 2016-07-13 11:15:48 PDT
(In reply to comment #4) > Comment on attachment 283344 [details] > Patch > > ok. fix the link Fixed.
Jiewen Tan
Comment 7 2016-07-13 15:01:07 PDT
Created attachment 283575 [details] Patch
Jiewen Tan
Comment 8 2016-07-13 17:09:19 PDT
Committed r203201: <http://trac.webkit.org/changeset/203201>
Note You need to log in before you can comment on or make changes to this bug.