Bug 159622

Summary: Move parsing of subscriptshift and superscriptshift from rendering to element classes
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: MathMLAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 120069, 156792    
Bug Blocks: 156536    
Attachments:
Description Flags
Patch darin: review+

Frédéric Wang (:fredw)
Reported 2016-07-11 07:07:42 PDT
This is bug 156536 for the subscriptshift and superscriptshift attributes.
Attachments
Patch (19.15 KB, patch)
2016-07-18 06:06 PDT, Frédéric Wang (:fredw) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2016-07-11 07:09:48 PDT
These attributes are currently parsed in RenderMathMLScripts.
Frédéric Wang (:fredw)
Comment 2 2016-07-18 06:06:49 PDT
Created attachment 283902 [details] Patch
Darin Adler
Comment 3 2016-07-18 10:02:30 PDT
Comment on attachment 283902 [details] Patch The constructor of RenderMathMLScripts should also be changed to take MathMLScriptsElement& instead of Element&.
Frédéric Wang (:fredw)
Comment 4 2016-07-18 21:57:23 PDT
(In reply to comment #3) > The constructor of RenderMathMLScripts should also be changed to take > MathMLScriptsElement& instead of Element&. I can not do that now since this renderer is also used for munder/mover/munderover but will consider it in bug 159625 and keep it in mind for other renderers too.
Frédéric Wang (:fredw)
Comment 5 2016-07-18 22:43:46 PDT
Committed r203396: <http://trac.webkit.org/changeset/203396>
Note You need to log in before you can comment on or make changes to this bug.