Bug 159621

Summary: Red and blue colors are swapped in video rendered through WebGL when GSTREAMER_GL is enabled
Product: WebKit Reporter: Olivier Blin <olivier.blin>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, mcatanzaro, pnormand, yoon, zan
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 159673    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Olivier Blin
Reported 2016-07-11 07:04:49 PDT
When a video is rendered through WebGL, and GSTREAMER_GL is enabled, red and blue colors are swapped. This occurs for example with the following videos: http://www.scirra.com/labs/bugs/webglvideo/ http://www.dailymotion.com/embed/video/x4jiicp?autoplay=1 This seems to be because ImageGStreamerCairo expects video frames in either BGRA or ARGB, while when GSTREAMER_GL is enabled, createVideoSinkGL() forces a RGBA format. Without GSTREAMER_GL, the rendering is fine since VideoSinkGStreamer uses either BGRA or ARGB.
Attachments
Patch (2.73 KB, patch)
2016-07-11 07:09 PDT, Olivier Blin 		no flags
DetailsFormatted DiffDiff
Patch (3.14 KB, text/plain)
2016-07-11 08:56 PDT, Olivier Blin 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Olivier Blin
Comment 1 2016-07-11 07:09:14 PDT
Created attachment 283315 [details] Patch
Olivier Blin
Comment 2 2016-07-11 07:10:02 PDT
This patch fixes the issue for me, but I am not sure if this can cause performance regression.
WebKit Commit Bot
Comment 3 2016-07-11 07:45:18 PDT
Comment on attachment 283315 [details] Patch Clearing flags on attachment: 283315 Committed r203059: <http://trac.webkit.org/changeset/203059>
WebKit Commit Bot
Comment 4 2016-07-11 07:45:22 PDT
All reviewed patches have been landed. Closing bug.
Olivier Blin
Comment 5 2016-07-11 08:56:05 PDT
Reopening to attach new patch.
Olivier Blin
Comment 6 2016-07-11 08:56:09 PDT
Created attachment 283318 [details] Patch
Philippe Normand
Comment 7 2016-07-11 09:04:54 PDT
What does this patch have to do with this bug? :)
Olivier Blin
Comment 8 2016-07-11 09:05:02 PDT
Comment on attachment 283318 [details] Patch Wrong bug, sorry
WebKit Commit Bot
Comment 9 2016-07-12 06:02:12 PDT
Re-opened since this is blocked by bug 159673
Olivier Blin
Comment 10 2016-09-22 05:57:50 PDT
Fixed now that GPU-GPU WebGL video integration has landed, see bug 159928
Note You need to log in before you can comment on or make changes to this bug.